Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material3 Themes UI Upgrade #162

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

gabriel-vanca
Copy link
Contributor

@gabriel-vanca gabriel-vanca commented Sep 6, 2024

Changelog:

  1. This updates MaterialDesignThemes.MahApps.
  2. This now requires Material 3 so it makes the required changes in App.xaml and MainWindows.xaml in that regard.
  3. I've also increased slightly the height of the MainWindow.
  4. Font has been changed from the ugly Consolas to Source Code Pro (https://github.com/adobe-fonts/source-code-pro) which is more clear-looking. Presumably the installer will need to pack this font.
  5. It also cleans up the files a bit and adds some clarifying comments.

⚠️ Note that this changes the look of the UI. I didn't change any of the colours myself, this is simply how Material 3 looks.
See below the new look. I'm not thrilled about it, but think it's an improvement over the old one.

Dark Mode:

image

Light Mode (does anyone still use this?):

image

🗒️ Note: Ignore the top header, that's just from the VS XAML debugger.

Old font (Consolas):

image

New font (Adobe Source Code Pro):

image

image

@coenm
Copy link
Owner

coenm commented Sep 7, 2024

Thanks for the effort. It's a lot for me right now to review using the Github webpage. Probably after the weekend i will checkout this PR on my machine in order to do a good review.

@coenm
Copy link
Owner

coenm commented Sep 9, 2024

image

This is how it looks like on my machine. So that would be the light mode i guess ;-)

@gabriel-vanca
Copy link
Contributor Author

Yep, that's light mode. I'd suggest locking it in Dark Mode for now as the Light Mode is neither light nor very clear (black text on dark grey background).

  <!--  Material Design  -->
  <materialDesign:BundledTheme
      BaseTheme      = "Inherit"
      PrimaryColor   = "LightBlue"
      SecondaryColor = "LightBlue"
      />

would simply need to be changed to:

  <!--  Material Design  -->
  <materialDesign:BundledTheme
      BaseTheme      = "Dark"
      PrimaryColor   = "LightBlue"
      SecondaryColor = "LightBlue"
      />

(lines 34-39 in App.xaml)

Maybe I can do a more comprehensive UI redesign at a later point which includes a proper Light Mode and that embraces WinUI3 and Fluent design.

@coenm
Copy link
Owner

coenm commented Sep 10, 2024

My current version looks like:

image

Which I like.

I'm happy to accept a PR that is updating the UI, but not if the light mode has black text like it has right now. I'm not using the black/dark mode and I don't like forcing others to do so

@coenm
Copy link
Owner

coenm commented Sep 10, 2024

In your PR, can you remove the this. keyword?

@gabriel-vanca
Copy link
Contributor Author

In your PR, can you remove the this. keyword?

✅ Done.

@coenm
Copy link
Owner

coenm commented Sep 13, 2024

My current version looks like:

image

Which I like.

I'm happy to accept a PR that is updating the UI, but not if the light mode has black text like it has right now. I'm not using the black/dark mode and I don't like forcing others to do so

Is it possible for you to make the text white in light mode (as it was). Then can accept your PR and merge this into main.
I really like you worked the UI as it is not my 'thing'.

Also the text in the help menu and the hamberger menu have black text.

image

image

@gabriel-vanca
Copy link
Contributor Author

Sure, I'll look into getting the UI right, including light mode. Apologies, I only saw your comment from 3 days ago now. GitHub notifications only showed me the comment about "this" for some reason 😅

@gabriel-vanca gabriel-vanca mentioned this pull request Sep 20, 2024
@gabriel-vanca
Copy link
Contributor Author

Recommending this PR is superseded by PR #184

@gabriel-vanca gabriel-vanca changed the title Material3 Themes UI Upgrade + Update MaterialDesignThemes.MahApps Material3 Themes UI Upgrade Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants