-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material3 Themes UI Upgrade #162
base: main
Are you sure you want to change the base?
Conversation
This now requires Material 3
…tCulture Material 3 Theme + Update Time conversion to use CultureInfo.InvariantCulture
Thanks for the effort. It's a lot for me right now to review using the Github webpage. Probably after the weekend i will checkout this PR on my machine in order to do a good review. |
Yep, that's light mode. I'd suggest locking it in Dark Mode for now as the Light Mode is neither light nor very clear (black text on dark grey background).
would simply need to be changed to:
(lines 34-39 in App.xaml) Maybe I can do a more comprehensive UI redesign at a later point which includes a proper Light Mode and that embraces WinUI3 and Fluent design. |
In your PR, can you remove the |
03756fa
to
aa16088
Compare
✅ Done. |
Is it possible for you to make the text white in light mode (as it was). Then can accept your PR and merge this into main. Also the text in the help menu and the hamberger menu have black text. |
Sure, I'll look into getting the UI right, including light mode. Apologies, I only saw your comment from 3 days ago now. GitHub notifications only showed me the comment about "this" for some reason 😅 |
1c4bbca
to
aa16088
Compare
Recommending this PR is superseded by PR #184 |
Changelog:
See below the new look. I'm not thrilled about it, but think it's an improvement over the old one.
Dark Mode:
Light Mode (does anyone still use this?):
🗒️ Note: Ignore the top header, that's just from the VS XAML debugger.
Old font (Consolas):
New font (Adobe Source Code Pro):