Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluent UI #184

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Fluent UI #184

wants to merge 36 commits into from

Conversation

gabriel-vanca
Copy link
Contributor

@gabriel-vanca gabriel-vanca commented Sep 20, 2024 •
edited
Loading

Decided to rethink PR #162 and switch to Fluent design as Material looks outdated, MahApps Metro is very slow in getting updates and FluentWpf has not been maintained for 3 years.

PR changelog:

  1. Deprecates MahApps Metro and FluentWpf . Switches to WpfUI (https://github.com/lepoco/wpfui)
  2. Deprecates Windows.Forms. Switches fully to Wpf.
  3. Deprecates Material and Metro theme components. Switches fully to Fluent design.
  4. Deprecates out-of-date controls (AcrylicContextMenu, AcrylicMenuItem, ZtextBox, Acrylic Helper, Windows Composition helper)
  5. Deprecates old icon system. Switches the the Windows native Segoe MDL2
  6. Deprecates Consolas typeface. Changes to Adobe Source Code Pro (https://github.com/adobe-fonts/source-code-pro)
  7. Adobe Source Code Pro is now embedded in the project.
  8. App now supports Dark Mode, Light Mode and High Constrast Mode (depending on Windows configuration)
  9. App will dynamically change its theme if Windows changes its theme.
  10. Simplifies the global hotkey logic.
  11. Simplifies the MainWindow hotkey logic,
  12. Simplifies the Taskbar management system (lots of old code remaining from RepoZ and its MacOS support now removed)
  13. Fixes the stay active window (activate by pressing F12) -> now the window can stay active once it loses focus. Closes Sticky Window (F12) #190 .
  14. Fixes some XAML bugs

Dark Mode:

image

Light Mode:

image

image

High Contrast Mode: (dark high contrast modes are coming later)

image

Ideas for future PRs:

  1. Theme is not saved to settings as of now.
  2. Still no option to change theme manually.
  3. Option to change the hotkey from settings.
  4. Clicking the Pin icon should unpin repositories
  5. Pinned repositories should be saved between sessions

@gabriel-vanca
Update MaterialDesignThemes.MahApps
90a34dc 
This now requires Material 3
@gabriel-vanca
Material 3 Theme + Update Time conversion to use CultureInfo.Invarian…
472869d 
…tCulture

Material 3 Theme +  Update Time conversion to use CultureInfo.InvariantCulture
@gabriel-vanca
Some additional comments and styling
f88e26b
@gabriel-vanca
App.xaml.cs Code cleanup
2b0b85d
@gabriel-vanca
MainWindow.xaml.cs code cleanup
4745d23
@gabriel-vanca
App.xaml cleanup
4e3da1d
@gabriel-vanca
MainWindow.xaml Cleanup
1504068
@gabriel-vanca
this undo
aa16088
@gabriel-vanca
Update MahApps version
28224b1 
See discussion at MahApps/MahApps.Metro#4194 (comment)
@gabriel-vanca
New Theme
8715816 
Deprecated old MahApps and FluentWpf
Switched to WpfUI package
Added Fonts
@gabriel-vanca
Removing deprecated Controls.
d659c58
@gabriel-vanca
Fixed Hotkey bug. Deprecated more code.
78dd47b
@gabriel-vanca
Enabled manual MainWindow resize
439c914
@gabriel-vanca
HotKey adjustments
3ea7d41
@gabriel-vanca
Taskbar logic simplification
ed4e768 
Deprecated MacOS taskbar positioning logic
@gabriel-vanca
Simplified Hotkey service
04cb53d
@gabriel-vanca
Code Cleanup
ea77de9
@gabriel-vanca
Escape key code logic simplification
4858b06
@gabriel-vanca
code cleanup & fixes
4f0a34e
@gabriel-vanca
App.xaml.cs reformat
3a67a4d
@gabriel-vanca
App.xaml.cs indentation
d556ac2
@gabriel-vanca
notes
4548e61
@gabriel-vanca
fixed flashing problem
4ed3da5
@gabriel-vanca
code cleanup
8442640
@gabriel-vanca
code cleanup
0db30e2
@gabriel-vanca
UI cleaning
c817ac3
@gabriel-vanca
UI fixes and crashing notes
e906dbf
@gabriel-vanca
Unpin button (not implemented)
a6be869
@gabriel-vanca
Fixes StayActiveWindow
5b04722
@gabriel-vanca
Fixed critical Thread safety issue
24ab2bd
@gabriel-vanca
Copy link
Contributor Author

gabriel-vanca commented Sep 20, 2024 •
edited
Loading

@coenm , Apologies for putting so much in one PR. Replacing some UI things required replacing others and that broke other things, so it kind of required re-writing much of the MainWindow logic. And sorry about the large number of files; they're mostly fonts, themes and colour palettes.

This was referenced Sep 20, 2024
Open
Open
Open
Open
@coenm coenm mentioned this pull request Sep 27, 2024
Open
@gabriel-vanca gabriel-vanca marked this pull request as draft October 15, 2024 23:40
@gabriel-vanca gabriel-vanca marked this pull request as ready for review October 15, 2024 23:40
@gabriel-vanca
Copy link
Contributor Author

Hi @coenm , let me know if you're still considering this PR as I had a few more UI-related ideas that depend on this PR.

@coenm
Copy link
Owner

coenm commented Nov 25, 2024

Hi @coenm , let me know if you're still considering this PR as I had a few more UI-related ideas that depend on this PR.

Hi @gabriel-vanca ,

Yes, I'm still open for an UI update. However, I liked your dark mode in PR #162 more compared to this one. Also, both PR's had some 'issues' or additions I didn't like and were blocking for me.

If you are still willing to put some time into RepoM (which i'm really grateful for), we should come up with some plan first before you putting in all this effort.

@gabriel-vanca
Copy link
Contributor Author

Sure, @coenm , I'd like that. The UI framework in the previous PR is deprecated, so I suggest we should use this newer one. The theme can be changed easily to be closer to the theme in the old one.

What do you have in mind regarding blocking additions and changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sticky Window (F12)
2 participants
@gabriel-vanca @coenm