Default packages – 6-beta-2 bugfix #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I returned |
BrianHenryIE
changed the title
|
This looks solid. Great that you’ve added tests for the verification logic as well. Will test this soon, to see how it gets along with my work in #47, but this should go into 0.6 anyway. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously merged default-packages PR #34 didn't work in the beta.
When that didn't work, I noticed couple of things: the parsing of the config didn't output a single line "missing packages key" and then the attempt to use the null object caused further verbose error messages.
Now it defaults to an empty array, prefers
composer->extra->mozart->packagesand falls back tocomposer->requireif available.The unit tests I wrote are only to check
composer.jsonexists, is valid json, and has theextra->mozartkeys as objects. It wasn't until I opened the PR I see how I could've put in a mockReplacerto fully test the changes. I should read a book on PHP!