fix: Redirect to 404 Page When Note is Not Found #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tushar504
commented
Nov 16, 2024
Tushar504
commented
- This PR adds try catch block to redirect user to 404 not found error page as described in Issue Closes Redirect to 404 Page When Note is Not Found #276
- updates the useNote service load method.
neSpecc
reviewed
Nov 16, 2024
e11sy
reviewed
Nov 19, 2024
e11sy
reviewed
Nov 20, 2024
src/application/router/routes.ts
Outdated
Comment on lines
187
to
197
| path: '/error', | ||
| component: ErrorPage, | ||
| meta: { | ||
| layout: 'fullpage', | ||
| pageTitleI18n: 'pages.notFound', | ||
| pageTitleI18n: 'pages.error', | ||
| discardTabOnLeave: true, | ||
| }, | ||
| props: { | ||
| code: 404, | ||
| }, | ||
| props: route => ({ | ||
| code: route.query.code, | ||
| customMessage: route.query.message, | ||
| }), |
There was a problem hiding this comment.
404 page was actually needed (this was a syntax for each unexpected url, that would show 404 page not found)
we need to create separate /error page, that should have statusCode property and show different info by different status code
There was a problem hiding this comment.
also better to use route.params for code prop
e11sy
reviewed
Dec 3, 2024
Comment on lines
+3
to
+7
| /** | ||
| * Domain error thrown when unknown error occurs | ||
| */ | ||
| export default class ApiError extends DomainError { | ||
| /** |
There was a problem hiding this comment.
i think, that DomainError actually extends ApiError
There was a problem hiding this comment.
Actually, currently it is not needed, I had created the ApiError to consider it as default error, to check api error response is instance of ApiError or not,
neSpecc
reviewed
Dec 4, 2024
neSpecc
reviewed
Dec 14, 2024
neSpecc
reviewed
Dec 25, 2024
neSpecc
reviewed
Dec 26, 2024
neSpecc
approved these changes
Dec 26, 2024
src/application/services/useNote.ts
Outdated
Comment on lines
167
to
169
| /** | ||
| * @todo try-catch domain errors | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @todo try-catch domain errors | |
| */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.