Skip to content

🤖 refactor: auto-cleanup#2244

Open
github-actions[bot] wants to merge 10 commits intomainfrom
auto-cleanup
Open

🤖 refactor: auto-cleanup#2244
github-actions[bot] wants to merge 10 commits intomainfrom
auto-cleanup

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 7, 2026 •
edited
Loading

Summary

Periodic auto-cleanup: remove dead code, fix stale config, deduplicate helpers, and tighten module exports.

Latest Change

  • Remove dead timing stats types from WorkspaceStore: Remove StreamTimingStats, ModelTimingStats, and SessionTimingStats interfaces that were defined but never referenced. The authoritative versions live in src/common/orpc/schemas/workspaceStats.ts. Net -74 lines.
Previous changes
  • Remove dead code and narrow exports in agentTools: Remove collectToolConfigsFromDefinitionGraph (exported but never imported anywhere) and its supporting AgentToolsLike interface. Also make isToolEnabledByConfigs and isToolEnabledInResolvedChain module-private since they are only called within the same file. Net -51 lines.
  • Deduplicate onboarding wizard splash ID constant.
  • Deduplicate MessageWindow blocks in UserMessage.
  • Inline single-use resolveForkRuntimeConfigs into its only caller.
  • Remove dead fuzzy-search helpers from fuzzySearch.ts.
  • Deduplicate ConnectionHealth interface from SSH2ConnectionPool.ts.
  • Delete src/common/utils/tools/taskToolTypeGuards.ts: Dead module with zero imports.
  • Delete src/common/utils/ai/providerFactory.ts: Dead since folder restructure.
  • Fix stale ESLint dynamic-import override paths.
  • Remove dead isStreamingPart type guard from messageUtils.ts.
  • Deduplicate formatDuration into shared utility.
  • Remove dead formatNewCommand, ThemeToggleButton, canonicalModelId, hasSubtitle prop.
  • Deduplicate compaction type guards into shared module.
  • Remove dead re-exports from RightSidebar.tsx.
  • Rename partialService.test.ts → historyService.partial.test.ts.
  • Fix orphaned JSDoc comment on UpdaterService.getStatus().
  • Deduplicate normalizeAgentId, getProviderDisplayName, getCustomModels/getAllCustomModels.
  • Remove dead backward-compat aliases in codexOauthAuth.ts and re-exports.
  • Unexport file-private helpers in modelEntries.ts.
  • Remove dead pendingReplayReset field from WorkspaceStore.ts.
  • Remove dead onLogEntry, formatPendingCommand, parseGitShowBranchForStatus, path helpers.
  • Remove dead ChatInputProps barrel re-export.
  • Unexport file-private isBashOutputTool.
  • Remove dead code in chatEditing.ts.

Validation

  • make typecheck passes
  • make static-check passes (excluding shfmt not available in CI env)
  • resolveToolPolicy.test.ts — 13/13 tests pass
  • Verified removed exports have zero imports across the codebase

Auto-cleanup checkpoint: 5197edb

Generated with mux · Model: anthropic:claude-opus-4-6 · Thinking: xhigh

@github-actions github-actions bot force-pushed the auto-cleanup branch 9 times, most recently from e189eda to d4c61c6 Compare February 9, 2026 08:23
@ThomasK33 ThomasK33 mentioned this pull request Feb 9, 2026
Open
@github-actions github-actions bot force-pushed the auto-cleanup branch 20 times, most recently from ed0fc4f to 9fb6874 Compare February 13, 2026 04:42
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Feb 18, 2026

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 18, 2026

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Feb 18, 2026

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions github-actions bot force-pushed the auto-cleanup branch 2 times, most recently from 2eb54f2 to 8fe6c3f Compare February 18, 2026 08:21
@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 18, 2026

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Feb 18, 2026

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 18, 2026

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Feb 18, 2026

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions github-actions bot force-pushed the auto-cleanup branch 5 times, most recently from a2ba655 to 993fc32 Compare February 19, 2026 20:12
@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 19, 2026

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Feb 19, 2026

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Mux Auto-Cleanup and others added 10 commits February 20, 2026 12:06
refactor: deduplicate ConnectionHealth interface from SSH2ConnectionPool
5bc0fad 
ConnectionStatus and ConnectionHealth were identically defined in both
sshConnectionPool.ts and SSH2ConnectionPool.ts. Since SSH2ConnectionPool
already imports SSHConnectionConfig from sshConnectionPool, extend the
import to include ConnectionHealth (ConnectionStatus is used transitively
through ConnectionHealth, so no direct import needed).
refactor: remove dead fuzzy-search helpers superseded by commandPalet…
c694cde 
…teRanking

After PR #2492 introduced commandPaletteRanking.ts, the higher-level
wrappers fuzzySubsequenceMatch, matchesAllTerms, scoreAllTerms (and the
private fuzzySubsequenceMatchNormalized) lost all production callers.

Remove the dead functions and their corresponding tests. The low-level
primitives (normalizeFuzzyText, splitQueryIntoTerms, scoreSingleTermNormalized)
remain — they are actively used by commandPaletteRanking.ts.
refactor: inline single-use resolveForkRuntimeConfigs into its only c…
f273f69 
…aller
refactor: remove dead execFileAsync function and ExecFileAsyncOptions…
9d6e4dd 
… interface

execFileAsync and its ExecFileAsyncOptions interface were exported from
disposableExec.ts but never imported anywhere in the codebase. This also
removes the now-unused 'spawn' import from child_process.
refactor: deduplicate MessageWindow blocks in UserMessage
d2738da 
The recent truncation refactoring (#2498) removed the truncation
reminder JSX but left two near-identical <MessageWindow> return
blocks (one for terminal output, one for user content) sharing the
same 5 props. Merge into a single return with conditional children.
refactor: deduplicate onboarding wizard splash ID constant
17f9432 
The string "onboarding-wizard-v1" was duplicated in both index.ts (registry)
and SplashScreenProvider.tsx (pause logic). Export a single
ONBOARDING_WIZARD_SPLASH_ID constant from index.ts and import it in
SplashScreenProvider.tsx.
refactor: remove dead code and narrow exports in agentTools
3046e09 
- Remove `collectToolConfigsFromDefinitionGraph`: exported function never
  imported anywhere (dead code).
- Remove `AgentToolsLike` interface: only used by the removed dead function.
- Make `isToolEnabledByConfigs` and `isToolEnabledInResolvedChain` module-
  private: both are only called within agentTools.ts itself.

Net: -51 lines, cleaner public API surface for the module.
refactor: remove unused getSegmentLabel export
d497dbe 
The function was exported from tokenMeterUtils.ts but never imported
anywhere in the codebase. Removing dead code.
refactor: deduplicate escapeRegex helper in HunkViewer
32e6e3d 
The escapeRegexForHighlight function in HunkViewer.tsx was an exact
duplicate of escapeRegex in highlightSearchTerms.ts (both introduced
across separate PRs). Export the existing escapeRegex and import it
in HunkViewer, removing the duplicate.
refactor: remove dead timing stats types from WorkspaceStore
574682c 
Remove StreamTimingStats, ModelTimingStats, and SessionTimingStats
interfaces that are defined but never used. The authoritative versions
of ModelTimingStats and SessionTimingStats live in
src/common/orpc/schemas/workspaceStats.ts (inferred from Zod schemas).
StreamTimingStats has no equivalent anywhere — purely dead code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants

Comments