Release/1.0.0 #15
Draft
Release/1.0.0 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Przemek Bieliński <[email protected]> * ErrorCollector for Pipes::Context * Store error passed to 'halt' in the error collectors errors hash in the :base key. Add 'error' method returning this error for backwards compatibility. * Update gem version
* strong context elements v1-simple * tests for strong context elements * extract _merge_context_elements method * rename 'cls' to 'klass' * reformat _validate_ctx * reformat tests and add tests for require_context
TarasJan
reviewed
Nov 10, 2020
spec/pipe_spec.rb
Outdated
| context 'when required context element present with valid type' do | ||
| let(:pipe) { ProvidingNumericChild | RequiringNumericChild } | ||
|
|
||
| it 'raises InvalidType' do |
There was a problem hiding this comment.
This should most likely be it does not raise
TarasJan
force-pushed
the
release/1.0.0
branch
from
50b503f to
ff2e5bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.