Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: review github CI on PHP8.4 #9255

Draft
wants to merge 5 commits into
base: 4.6
Choose a base branch
from

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Nov 5, 2024

Description
Review without ignore-platform-php, Reference to #9116 latest checklist.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr changed the title refactor: review github CI on PHP8.4 refactor: review github CI on PHP8.4 Nov 5, 2024
@neznaika0
Copy link
Contributor

php-cs-fixer:

Note Each new PHP version requires a huge effort to support the new syntax. That's why the latest PHP version might not be supported yet. If you need it, please, consider supporting the project in any convenient way, for example with code contribution or reviewing existing PRs. To run PHP CS Fixer on yet unsupported versions "at your own risk" - leverage the PHP_CS_FIXER_IGNORE_ENV.

@ddevsr ddevsr added github_actions Pull requests that update Github_actions code 4.6 labels Nov 6, 2024
@ddevsr
Copy link
Collaborator Author

ddevsr commented Nov 8, 2024

FakerPHP/Faker already merge, release soon on v1.24.

@github-actions github-actions bot added the stale Pull requests with conflicts label Nov 21, 2024
Copy link

👋 Hi, @ddevsr!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@ddevsr ddevsr removed the stale Pull requests with conflicts label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.6 github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants