Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: twitter example for android & improve performance #7

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

e-younan
Copy link
Member

@e-younan e-younan commented Mar 29, 2023

Description

This PR introduces a fix for Android bugs that were observed, and improves the performance by removing the layout animation that modifies the height of the Twitter profile banner in favour of a translation.

Motivation and Context

These changes were introduced since a few bugs were observed on Android.

  1. The BlurView component had a bug where it was taking up the whole screen on Android
  2. The animation performance on Android was not as smooth as iOS - this is due to the layout animation on the padding of the header. I have removed this in favour of a translation.
  3. A blank screen has been showing up on Android when the screen is opened sometimes. I have narrowed the issue down to it being due to the BlurView. Apparently, this is a bug that has already been reported. For now, we will disable the BlurView on Android <= 11 in favour of a simple dark mask.

How Has This Been Tested?

This has been tested on a physical Samsung S9+ and a Pixel 6 Pro emulator.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have followed the guidelines in the README.md file.
  • I have updated the documentation as necessary.
  • My changes generate no new warnings.

Screenshots

android-twitter-header.mov

@e-younan e-younan merged commit 4ccc6d6 into main Mar 29, 2023
@e-younan e-younan deleted the fix/twitter-example branch March 29, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant