Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cancel_connectirng #2226

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Feature/cancel_connectirng #2226

merged 4 commits into from
Aug 26, 2024

Conversation

worksofliam
Copy link
Contributor

Changes

Adds cancel button to connection progress popup.

How to test this PR

Try these different tests:

  • Start connecting to a system, then press cancel
  • Connect to a system successfully
  • Start connecting to a system, then press cancel, then successfully connect to another system

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

sebjulliand
sebjulliand approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Nice and easy, great change!

@sebjulliand
Copy link
Collaborator

@worksofliam merge whenever you want!

@worksofliam worksofliam merged commit 360778b into master Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worksofliam @sebjulliand