Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/typings_2_12_0 #2173

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Fix/typings_2_12_0 #2173

merged 2 commits into from
Jul 18, 2024

Conversation

worksofliam
Copy link
Contributor

Changes

Simply adds a hard check before accessing properties of buttons.

How to test this PR

Examples:

  1. npm run typings executes as expected

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

sebjulliand
sebjulliand approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@sebjulliand sebjulliand merged commit 0b52845 into master Jul 18, 2024
1 check passed
@sebjulliand sebjulliand deleted the fix/typings_2_12_0 branch July 18, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

@chrjorgensen chrjorgensen Awaiting requested review from chrjorgensen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worksofliam @sebjulliand