-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open path from URI #2038
base: master
Are you sure you want to change the base?
Open path from URI #2038
Conversation
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
👋 A new build is available for this PR based on 7a6a00b. |
If they have no current connection would it beneficial to allow the user to pick one? Instead of a warning message. Also I am unsure the purpose of the host param as the below two scenarios arent covered:
|
@julesyan Thanks for your great testing.
|
Signed-off-by: worksofliam <[email protected]>
@julesyan This works now:
|
Tested locally and found no more issues, looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@worksofliam I did some testing with this change and noticed a few issues. Refer to my comments below.
window.showWarningMessage(t(`uriOpen.missingPath`)); | ||
} | ||
} else { | ||
window.showWarningMessage(t(`uriOpen.noConnection`)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
window.showWarningMessage(t(`uriOpen.noConnection`)); | |
window.showWarningMessage(t(`uriOpen.missingPath`)); |
commands.executeCommand(`code-for-ibmi.openEditable`, path); | ||
} | ||
} else { | ||
window.showWarningMessage(t(`uriOpen.missingPath`)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the example you gave in this PR:
vscode://halcyontechltd.code-for-ibmi/open?path=/home/liama/xyz
I assume this means that the file will be opened based on the active connection. If so, is this else block a mistake because this will not open any file and just give this warning even though I am connected. In the case there is no connection, shouldn't the message be:
window.showWarningMessage(t(`uriOpen.noConnection`));
Changes
How to test this PR
vscode://halcyontechltd.code-for-ibmi/open?path=/home/liama/xyz
vscode://halcyontechltd.code-for-ibmi/open?host=1.1.1.1&path=/home/liama/xyz
Examples:
Checklist
console.log
s I added