Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/typings_issue #1430

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Fix/typings_issue #1430

merged 2 commits into from
Jul 10, 2023

Conversation

worksofliam
Copy link
Contributor

Changes

Am unable to run npm run typings for our type package due to two issues:

  1. Invalid types in Terminal.ts when resizing the terminal
  2. Missing package named ssh2-streams. Added a dev dep since we don't need it in production.

I can now:

  • npm run package and
  • npm run typings

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam added this to the 2.0.0 release milestone Jul 10, 2023
sebjulliand
sebjulliand approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Terminal still work and types are generated.

@sebjulliand sebjulliand merged commit bcb1b3f into master Jul 10, 2023
1 check passed
@sebjulliand sebjulliand deleted the fix/typings_issue branch July 10, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

@chrjorgensen chrjorgensen Awaiting requested review from chrjorgensen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@worksofliam @sebjulliand