Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking for directory in safe delete mode #1410

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Fix checking for directory in safe delete mode #1410

merged 1 commit into from
Jul 4, 2023

Conversation

chrjorgensen
Copy link
Collaborator

Changes

This PR will fix checking if the node is a directory when Safe Delete Mode is active:
Check for node context directory instead if node path ending in /.

Checklist

  • have tested my change

@chrjorgensen chrjorgensen self-assigned this Jul 3, 2023
@chrjorgensen chrjorgensen added the bug A confirmed issue when something isn't working as intended label Jul 3, 2023
sebjulliand
sebjulliand approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change. Simple and makes the process safer. Let's merge!

@sebjulliand sebjulliand merged commit 1bcf17d into codefori:master Jul 4, 2023
1 check passed
@chrjorgensen chrjorgensen deleted the fix/dir-safe-delete branch November 24, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

@worksofliam worksofliam Awaiting requested review from worksofliam

Assignees

@chrjorgensen chrjorgensen

Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrjorgensen @sebjulliand