Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use temp member to save new file #1403

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

worksofliam
Copy link
Contributor

Changes

  • Attempts to insert new file into temporary table first. This is good because we can check the file will be saved without clearing out the original member first.
  • Seems to have seriously improved the performance of member saving

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam requested review from sebjulliand and chrjorgensen and removed request for sebjulliand June 30, 2023 15:57
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and works perfectly!

@chrjorgensen chrjorgensen merged commit c707a12 into master Jun 30, 2023
1 check passed
@chrjorgensen
Copy link
Collaborator

I did not feel any speed improve - which would also not be logical, since two more steps is introduced to the save operation.
However, that was not the point either - the point being to have a safer save, not saving half a member. And the additional steps are almost not noticeable and a good compromise for the safer save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants