Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle editor saving in any case when running actions #1399

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

sebjulliand
Copy link
Collaborator

Changes

Fixes #1398.

When running action without using ctrl+e and if the action is ran for the document currently being edited, the save/auto save feature was not triggered.

This PR fixes this behavior and save/auto save will always occur if the action is about to be run for the document being edited, regardless of the action's origin.

Checklist

  • have tested my change

@sebjulliand sebjulliand self-assigned this Jun 28, 2023
@sebjulliand sebjulliand linked an issue Jun 28, 2023 that may be closed by this pull request
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Simple and effective - your trademark! 😉

@chrjorgensen chrjorgensen merged commit 3886f16 into master Jun 28, 2023
1 check passed
@sebjulliand sebjulliand deleted the feature/actionAutosaveFromEditor branch June 28, 2023 15:00
@sebjulliand
Copy link
Collaborator Author

@chrjorgensen Oh you! 🤩
Thanks for testing and validating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto Save for Actions when run from an editor Save on Actions not working
2 participants