Add Create Quick Filter action

[SanjulaGanepola]

Changes

Add Create Quick Filter action that allows users to quickly type a filter of the following format: LIB* or LIB/OBJ/MBR.MBRTYPE (OBJTYPE) where each parameter is optional except the library. For parameters which are not provided, the defaults will be used.

Checklist

• have tested my change
• updated relevant documentation
• Remove any/all console.logs I added
• eslint is not complaining
• have added myself to the contributors' list in CONTRIBUTING.md
• for feature PRs: PR only includes one feature enhancement.

[SanjulaGanepola]

@liam I decided to go with the symbol-text icon as it looked like a better fit (let me know if you think list-filter might still be better). Also, let me know if you think the regular expression used for parsing can be improved.

[worksofliam]

@SanjulaGanepola We are going to need a matching PR in the docs repo for this functionality too before this can be merged. Thanks!

https://github.com/halcyon-tech/docs/tree/main/docs

[SanjulaGanepola]

Created a PR for the doc updates: codefori/docs#10

[sebjulliand]

Good job, it works as expected. I'd suggest a few changes to make the code flow unambiguous.

I also have two comments:

• Is there an actual need to create a filter to list libraries?
• There is a slight possibility that the new filter has the same name as an existing one. It may be better to name it using newFilter's content and check if this name is already taken (in which case you could append _1 to it).

[sebjulliand]

Since the input is validated by the regex, is there any actual way this block could be reached?
If no, remove it and remove both node and newFilter as they serve no purpose.

[SanjulaGanepola]

Since we are using validateInput with the regex already, this block should not be reachable so I removed it. Thanks for catching that

[sebjulliand]

Do this only if a new filter has been actually added (i.e. if newFilter is ok).

[SanjulaGanepola]

This is already contained inside of the if(newFilter) so I think we know for sure the filter is added.

[SanjulaGanepola]

• Is there an actual need to create a filter to list libraries?

Although it may not be very common, I think it is more to support users who may want to browse for a library they would like to modify/delete/etc. Also in Project Explorer, we contribute several inline and right-click menu actions on libraries that include updating the library list, setting variables, or for migrating source to the local project.

• There is a slight possibility that the new filter has the same name as an existing one. It may be better to name it using newFilter's content and check if this name is already taken (in which case you could append _1 to it).

The naming logic I used is the same as the default behaviour of the current Create Filter action (https://github.com/halcyon-tech/vscode-ibmi/blob/master/src/webviews/filters/index.js#L47) where the numbering is based on the current number of filters. Thus, I don't think it could be possible for the name to be an existing one? Could you provide a scenario in which it could happen?

[sebjulliand]

Changes look good, thanks! On second thought, the possibility that a "Filter 3" already exists when it gets created is so slim we won't worry about it for now.