Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update command contributions and use CPYLIB for Copy Object command #1392

Merged

Conversation

SanjulaGanepola
Copy link
Contributor

@SanjulaGanepola SanjulaGanepola commented Jun 26, 2023

Changes

  • Update when clause for commands in package.json to specify the view
  • Remove Move Object command from libraries
  • Update Copy Object command to use CPYLIB

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam
Copy link
Contributor

@SanjulaGanepola Usually I am more strict about this, but I'd expect these two changes (the package.json changes and command updates) to be in two separate PRs. It's ok for now.

@SanjulaGanepola
Copy link
Contributor Author

Will keep that in mind for future PRs. Thanks

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me - thanks!

@chrjorgensen chrjorgensen merged commit d840abf into codefori:master Jun 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants