Upgrade node-ssh to 13.1 #1328
Merged
Upgrade node-ssh to 13.1 #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liam Allan <[email protected]>
|
Tests are passing as expected under this branch: 
|
sebjulliand
previously approved these changes
May 31, 2023
chrjorgensen
previously approved these changes
Jun 27, 2023
|
Ok, I think we've deemed this mergeable. I will do this today after resolving the conflict. |
Signed-off-by: Liam Allan <[email protected]>
worksofliam
dismissed stale reviews from chrjorgensen and sebjulliand
via
bb346d6
|
👋 A new build is available for this PR based on bb346d6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Finally upgraded node-ssh to 13.1. We failed to do it in the past because ssh2 (a sub dep) now builds binaries for the package, but they are optional. I have updated our webpack configuration to ignore the errors for those binary files.
See this issue for how someone else fixed it: mscdex/ssh2#1213
Checklist
console.logs I added