Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early polling marker changes from red to green on hover #69

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lucyq
Copy link
Member

@lucyq lucyq commented Oct 25, 2016

#62

@lucyq lucyq changed the title Marker changes color on hover Early polling marker changes from red to green on hover Oct 25, 2016
@lucyq
Copy link
Member Author

lucyq commented Oct 26, 2016

-removed extraneous bootstrap modal package
-expands div on marker click if div is collapsed

var collapsedToggle = Boolean(document.getElementById('#collapse-toggle'+i).getAttribute("aria-expanded"));

if (collapsedToggle) {
$('#collapse'+i).collapse('show');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this make its way into multiple pull requests :P we might not want to do this, based off some of the design stuff that @WheresHJ was showing, maybe we can talk about this on tuesday?

@lucyq
Copy link
Member Author

lucyq commented Oct 28, 2016

my bad! should've put that on a separate branch & PR. i'll take it out when i get home today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants