updated design #50
Merged
updated design #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdates bootstrap from 3.0.0 to 3.3.7.
fix jquery, map resize fix for tabs
|
I just added a commit to make it usable on mobile, so here's how that looks at the moment:
|
|
Great fix! One comment- with my browser maximized, the map is below the fold on the Election Day tab (similar to your first screenshot), so I have to know to scroll down in order to see the map. We might want to adjust this, but definitely not a blocker for merge. |
|
fixes #35 |
Closed
carpeliam
pushed a commit
that referenced
this pull request
Oct 27, 2016
* use OFFICIAL bootstrap sass instead of whatever this buggy one was. Updates bootstrap from 3.0.0 to 3.3.7. * initial redesigned site, no early info added yet. WIP for #35 * fix jquery, map resize fix for tabs * pin down jquery version (the updated bootstrap will upgrade it otherwise) * make it usable on mobile * adjust spinner position and make it not bigger than the button text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyo, here's the code from the redesign I showed around last night.
@thadk contributed a fix yesterday for the map rendering issue we saw - it turns out google maps doesn't get along with hidden elements too well but that part should be good now.
Boring but pertinent things about this code change
bower installto mess with people's setups (like it did mine). So I pinned the version of jquery to the version specified in our.bower.jsonScreenshots!