Refactor base stages #92
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| package assertions | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/codecrafters-io/kafka-tester/protocol/kafkaapi" | ||
| "github.com/codecrafters-io/tester-utils/logger" | ||
| ) | ||
|
|
||
| var apiKeyNames = map[int16]string{ | ||
| 1: "FETCH", | ||
| 18: "API_VERSIONS", | ||
| 75: "DESCRIBE_TOPIC_PARTITIONS", | ||
| } | ||
|
|
||
| var errorCodes = map[int]string{ | ||
| 0: "NO_ERROR", | ||
| 3: "UNKNOWN_TOPIC_OR_PARTITION", | ||
| 35: "UNSUPPORTED_VERSION", | ||
| 100: "UNKNOWN_TOPIC_ID", | ||
| } | ||
|
|
||
| type ApiVersionsResponseAssertion struct { | ||
| ActualValue kafkaapi.ApiVersionsResponse | ||
| ExpectedValue kafkaapi.ApiVersionsResponse | ||
| } | ||
|
|
||
| func NewApiVersionsResponseAssertion(actualValue kafkaapi.ApiVersionsResponse, expectedValue kafkaapi.ApiVersionsResponse) *ApiVersionsResponseAssertion { | ||
| return &ApiVersionsResponseAssertion{ | ||
| ActualValue: actualValue, | ||
| ExpectedValue: expectedValue, | ||
| } | ||
| } | ||
|
|
||
| func (a *ApiVersionsResponseAssertion) assertBody(logger *logger.Logger) error { | ||
| expectedErrorCodeName, ok := errorCodes[int(a.ExpectedValue.Body.ErrorCode)] | ||
|
|
||
| if !ok { | ||
| panic(fmt.Sprintf("CodeCrafters Internal Error: Expected %d to be in errorCodes map", a.ExpectedValue.Body.ErrorCode)) | ||
| } | ||
|
|
||
| if a.ActualValue.Body.ErrorCode != a.ExpectedValue.Body.ErrorCode { | ||
| return fmt.Errorf("Expected ErrorCode to be %d (%s), got %d", a.ExpectedValue.Body.ErrorCode, expectedErrorCodeName, a.ActualValue.Body.ErrorCode) | ||
| } | ||
|
|
||
| logger.Successf("✓ ErrorCode: %d (%s)", a.ActualValue.Body.ErrorCode, expectedErrorCodeName) | ||
|
|
||
| if err := a.assertAPIKeysArray(logger); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (a *ApiVersionsResponseAssertion) assertAPIKeysArray(logger *logger.Logger) error { | ||
| if len(a.ActualValue.Body.ApiKeys) < len(a.ExpectedValue.Body.ApiKeys) { | ||
| return fmt.Errorf("Expected API keys array to include atleast %d keys, got %d", len(a.ExpectedValue.Body.ApiKeys), len(a.ActualValue.Body.ApiKeys)) | ||
| } | ||
|
|
||
| logger.Successf("✓ API keys array length: %d", len(a.ActualValue.Body.ApiKeys)) | ||
|
|
||
| for _, expectedApiVersionKey := range a.ExpectedValue.Body.ApiKeys { | ||
| found := false | ||
|
|
||
| for _, actualApiVersionKey := range a.ActualValue.Body.ApiKeys { | ||
| if actualApiVersionKey.ApiKey == expectedApiVersionKey.ApiKey { | ||
| found = true | ||
|
|
||
| if actualApiVersionKey.MinVersion > expectedApiVersionKey.MaxVersion { | ||
| return fmt.Errorf("Expected min version %v to be < max version %v for %s", actualApiVersionKey.MinVersion, expectedApiVersionKey.MaxVersion, apiKeyNames[expectedApiVersionKey.ApiKey]) | ||
| } | ||
|
|
||
| // anything above or equal to expected minVersion is fine | ||
| if actualApiVersionKey.MinVersion < expectedApiVersionKey.MinVersion { | ||
| return fmt.Errorf("Expected API version %v to be supported for %s, got %v", expectedApiVersionKey.MinVersion, apiKeyNames[expectedApiVersionKey.ApiKey], actualApiVersionKey.MinVersion) | ||
| } | ||
|
|
||
| logger.Successf("✓ MinVersion for %s is <= %v & >= %v", apiKeyNames[expectedApiVersionKey.ApiKey], expectedApiVersionKey.MaxVersion, expectedApiVersionKey.MinVersion) | ||
|
|
||
| if actualApiVersionKey.MaxVersion < expectedApiVersionKey.MaxVersion { | ||
| return fmt.Errorf("Expected API version %v to be supported for %s, got %v", expectedApiVersionKey.MaxVersion, apiKeyNames[expectedApiVersionKey.ApiKey], actualApiVersionKey.MaxVersion) | ||
| } | ||
|
|
||
| logger.Successf("✓ MaxVersion for %s is >= %v", apiKeyNames[expectedApiVersionKey.ApiKey], expectedApiVersionKey.MaxVersion) | ||
| } | ||
| } | ||
|
|
||
| if !found { | ||
| return fmt.Errorf("Expected APIVersionsResponseKey array to include API key %d (%s)", expectedApiVersionKey.ApiKey, apiKeyNames[expectedApiVersionKey.ApiKey]) | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (a *ApiVersionsResponseAssertion) Run(logger *logger.Logger) error { | ||
| if err := NewResponseHeaderAssertion(a.ActualValue.Header, a.ExpectedValue.Header).Run(logger); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err := a.assertBody(logger); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package assertions | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/codecrafters-io/kafka-tester/protocol/kafkaapi/headers" | ||
| "github.com/codecrafters-io/tester-utils/logger" | ||
| ) | ||
|
|
||
| type ResponseHeaderAssertion struct { | ||
| ActualValue headers.ResponseHeader | ||
| ExpectedValue headers.ResponseHeader | ||
| } | ||
|
|
||
| func NewResponseHeaderAssertion(actualValue headers.ResponseHeader, expectedValue headers.ResponseHeader) *ResponseHeaderAssertion { | ||
| return &ResponseHeaderAssertion{ | ||
| ActualValue: actualValue, | ||
| ExpectedValue: expectedValue, | ||
| } | ||
| } | ||
|
|
||
| func (a *ResponseHeaderAssertion) assertCorrelationId(logger *logger.Logger) error { | ||
| if a.ActualValue.CorrelationId != a.ExpectedValue.CorrelationId { | ||
| return fmt.Errorf("Expected correlation_id to be %d, got %d", a.ExpectedValue.CorrelationId, a.ActualValue.CorrelationId) | ||
| } | ||
|
|
||
| logger.Successf("✓ correlation_id: %v", a.ActualValue.CorrelationId) | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (a *ResponseHeaderAssertion) Run(logger *logger.Logger) error { | ||
| return a.assertCorrelationId(logger) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Decoder Indentation Leak
The
decoder.BeginSubSection("response_header")call instage_2.go,stage_3.go, andstage_4.golacks a matchingEndCurrentSubSection(). This leaves the decoder's log indentation permanently increased for any subsequent logging operations.Additional Locations (2)
internal/stage_3.go#L71-L72internal/stage_4.go#L72-L73