feat(leaderboard): add route info metadata for anonymous access #3079
+47
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace allowsAnonymousAccess property with buildRouteInfoMetadata method returning RouteInfoMetadata to declare anonymous access. Refactor activate method to properly close function block. This update aligns with new route metadata conventions and improves route configuration clarity.
Add a new helper function to create leaderboard entries from sample data, reducing duplicate test setup code for both anonymous and authenticated user scenarios. Introduce a new test to verify leaderboard page viewing for anonymous users. This improves test clarity and maintainability.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| relatedCourseSlugs: ['redis', 'shell', 'sqlite', 'grep'].slice(0, Math.floor(sampleUserDatum.score / 50)), | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Test Behavior Altered by Dynamic Data
The createLeaderboardEntriesFromSampleData helper changes the "can switch languages" test's behavior. It dynamically calculates relatedCourseSlugs, replacing the test's original fixed array of two slugs with four for its sample data, which alters the test's intended validation.
Additional Locations (1)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will decrease total bundle size by 1.63kB (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
Files in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace allowsAnonymousAccess property with buildRouteInfoMetadata
method returning RouteInfoMetadata to declare anonymous access.
Refactor activate method to properly close function block. This update
aligns with new route metadata conventions and improves route
configuration clarity.