Course definitions for Redis/Pub-Sub stages #329

UdeshyaDhungana · 2025-07-15T07:15:37Z

No description provided.

coderabbitai · 2025-07-15T07:15:43Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

rohitpaulk · 2025-07-15T19:19:30Z

course-definition.yml

@@ -3878,3 +3878,40 @@ stages:
    name: "Blocking retrieval with timeout"
    difficulty: medium
    marketing_md: In this stage, you will add support for a non-zero timeout duration for the `BLPOP` command.
+
+  # Pub-Sub
+  - slug: "mx3"


We'll need to add the extension above to the extensions key too btw

rohitpaulk · 2025-07-15T19:19:47Z

stage_descriptions/pubsub_1_mx3.md

@@ -0,0 +1,51 @@
+In this stage, you’ll add support for the  `SUBSCRIBE` command.
+
+### The `SUBSCRIBE` Command


Not really reviewing these, assuming they're the same as slab for now

UdeshyaDhungana · 2025-07-16T04:28:22Z

Split stage 3 of pubsub
We test the modified behavior of ping in a separate stage as per the feedback

rohitpaulk · 2025-07-16T09:50:55Z

course-definition.yml

+
+  - slug: "lf1"
+    primary_extension_slug: "pub-sub"
+    name: "Change PING behavior"


Suggested change

name: "Change PING behavior"

name: "PING in subscribed mode"

rohitpaulk · 2025-07-16T09:51:27Z

stage_descriptions/pubsub_3_aw8.md

+
+The tester will then send a series of commands, which might be allowed or un-allowed for subscribed mode.
+
+For un-allowed command (like `SET`, `GET`, and `ECHO`) the tester will verify that your server responds with the following error:


Suggested change

For un-allowed command (like `SET`, `GET`, and `ECHO`) the tester will verify that your server responds with the following error:

For un-allowed commands (like `SET`, `GET`, and `ECHO`) the tester will verify that your server responds with the following error:

rohitpaulk · 2025-07-16T09:52:11Z

stage_descriptions/pubsub_3_aw8.md

+
+The tester only verifies that error message starts with "Can't execute '<command_name>'", so you're free to use a flexible error message and not stick to the exact format that Redis uses.
+
+For `SUBSCRIBE` command, the tester will verify that the response is its usual response.


Suggested change

For `SUBSCRIBE` command, the tester will verify that the response is its usual response.

For the `SUBSCRIBE` command, the tester will verify that the response is its usual response.

rohitpaulk · 2025-07-16T09:54:20Z

stage_descriptions/pubsub_3_aw8.md

+    - `Can't execute 'set' in subscribed mode`
+    - `can't execute 'SET' when one or more subscriptions exist`
+
+- In this stage, you'll only need to handle responding with errors in case of `SET`, `GET`, and `ECHO` commands. We will get to modifying the response of `PING` command in Subscribed mode in the next stage.


We don't mention that PING has a different response at all, so this note could be confusing to users. Let's instead mention just that fact:

- In subscribed mode, `PING` has a different response (it doesn't respond with `+PONG\r\n`). We'll get to this in later stages.

rohitpaulk · 2025-07-16T09:54:40Z

stage_descriptions/pubsub_4_lf1.md

@@ -0,0 +1,38 @@
+In this stage, you'll add support for modifying the response of `PING` command in the subscribed mode.
+
+### Subscribe Mode (Modification of `PING`)


Suggested change

### Subscribe Mode (Modification of `PING`)

### `PING` in subscribed mode

rohitpaulk · 2025-07-16T09:54:53Z

stage_descriptions/pubsub_4_lf1.md

@@ -0,0 +1,38 @@
+In this stage, you'll add support for modifying the response of `PING` command in the subscribed mode.


Suggested change

In this stage, you'll add support for modifying the response of `PING` command in the subscribed mode.

In this stage, you'll add support for responding to `PING` when a client is in subscribed mode.

rohitpaulk · 2025-07-16T09:55:54Z

stage_descriptions/pubsub_4_lf1.md

+
+### Subscribe Mode (Modification of `PING`)
+
+If a ping command is issued from a client after it enters the subscribed mode, the server does not respond with `+PONG\r\n`, which is the usual response of `PING` command. Instead, the response is a RESP-Array of two elements


Suggested change

If a ping command is issued from a client after it enters the subscribed mode, the server does not respond with `+PONG\r\n`, which is the usual response of `PING` command. Instead, the response is a RESP-Array of two elements

If a ping command is issued from a client after it enters subscribed mode, Redis does not respond with the usual response (`+PONG\r\n`). Instead it responds with a RESP array of two elements:

rohitpaulk · 2025-07-16T09:56:50Z

stage_descriptions/pubsub_4_lf1.md

+pong\r\n
+$0\r\n
+\r\n
+```


We should also test PING from a regular client after this to ensure the behaviour only changes for subscribed clients and not others.

rohitpaulk

Added notes specifically for the subscribed mode & ping stage - good to go once those are addressed!

- Rename stage description files to comply with the new format

- Add course definitions for Redis/Pub-Sub stages

bf74661

UdeshyaDhungana requested a review from rohitpaulk July 15, 2025 07:15

UdeshyaDhungana changed the title ~~- Add course definitions for Redis/Pub-Sub stages~~ Course definitions for Redis/Pub-Sub stages Jul 15, 2025

rohitpaulk reviewed Jul 15, 2025

View reviewed changes

rohitpaulk approved these changes Jul 15, 2025

View reviewed changes

UdeshyaDhungana added 2 commits July 16, 2025 09:45

Merge branch 'main' into pub-sub

428f713

- Split Subscribed mode into two stages

b1a33a6

UdeshyaDhungana requested a review from rohitpaulk July 16, 2025 04:28

rohitpaulk reviewed Jul 16, 2025

View reviewed changes

rohitpaulk approved these changes Jul 16, 2025

View reviewed changes

UdeshyaDhungana added 4 commits July 17, 2025 11:42

Merge branch 'main' into pub-sub

094c147

- Apply requested changes

1040397

- Rename stage description files to comply with the new format

fix: marketing md for lf1

2322e30

fix rename: add missing hyphens

76a1d14

UdeshyaDhungana merged commit b490b42 into main Jul 17, 2025
33 checks passed

UdeshyaDhungana deleted the pub-sub branch July 17, 2025 07:37

		@@ -0,0 +1,51 @@
		In this stage, you’ll add support for the `SUBSCRIBE` command.

		### The `SUBSCRIBE` Command


		The tester will then send a series of commands, which might be allowed or un-allowed for subscribed mode.

		For un-allowed command (like `SET`, `GET`, and `ECHO`) the tester will verify that your server responds with the following error:

	For un-allowed command (like `SET`, `GET`, and `ECHO`) the tester will verify that your server responds with the following error:
	For un-allowed commands (like `SET`, `GET`, and `ECHO`) the tester will verify that your server responds with the following error:


		The tester only verifies that error message starts with "Can't execute '<command_name>'", so you're free to use a flexible error message and not stick to the exact format that Redis uses.

		For `SUBSCRIBE` command, the tester will verify that the response is its usual response.

	For `SUBSCRIBE` command, the tester will verify that the response is its usual response.
	For the `SUBSCRIBE` command, the tester will verify that the response is its usual response.

		@@ -0,0 +1,38 @@
		In this stage, you'll add support for modifying the response of `PING` command in the subscribed mode.

		### Subscribe Mode (Modification of `PING`)

	### Subscribe Mode (Modification of `PING`)
	### `PING` in subscribed mode

	In this stage, you'll add support for modifying the response of `PING` command in the subscribed mode.
	In this stage, you'll add support for responding to `PING` when a client is in subscribed mode.


		### Subscribe Mode (Modification of `PING`)

		If a ping command is issued from a client after it enters the subscribed mode, the server does not respond with `+PONG\r\n`, which is the usual response of `PING` command. Instead, the response is a RESP-Array of two elements

Course definitions for Redis/Pub-Sub stages #329

Course definitions for Redis/Pub-Sub stages #329

Uh oh!

Conversation

UdeshyaDhungana commented Jul 15, 2025

Uh oh!

coderabbitai bot commented Jul 15, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

rohitpaulk Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

rohitpaulk Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

UdeshyaDhungana commented Jul 16, 2025

Uh oh!

rohitpaulk Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

rohitpaulk Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

rohitpaulk Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

rohitpaulk Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

rohitpaulk Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rohitpaulk Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rohitpaulk Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rohitpaulk Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

rohitpaulk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)

rohitpaulk Jul 16, 2025 •

edited

Loading

rohitpaulk Jul 16, 2025 •

edited

Loading

rohitpaulk Jul 16, 2025 •

edited

Loading