fix: make TestInstance duration_seconds nullable #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 90.22% 89.80% -0.43%
==========================================
Files 387 324 -63
Lines 11779 9472 -2307
Branches 2063 1688 -375
==========================================
- Hits 10628 8506 -2122
+ Misses 1052 902 -150
+ Partials 99 64 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swatinem
previously approved these changes
Oct 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
this will be used in cache rollup cron to determine which repo branch combos to run the cache test rollups task for
joseph-sentry
force-pushed
the
joseph/null-duration
branch
from
1b9d2be
to
cb95b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.