Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate useSelfHostedHasAdmins to TS Query V5 #3579

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the useSelfHostedHasAdmins hook over to the queryOptions API version SelfHostedHasAdminsQueryOpts

Ticket: codecov/engineering-team#2961

Notable Changes

  • Migrate useSelfHostedHasAdmins to SelfHostedHasAdminsQueryOpts
  • Update usage in MissingDesignatedAdmins
  • Fix MSW mock in App.test.tsx

@codecov-staging
Copy link

codecov-staging bot commented Dec 13, 2024

Bundle Report

Changes will decrease total bundle size by 3.08kB (-0.02%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.72MB 1.46kB (-0.03%) ⬇️
gazebo-staging-system 5.67MB 1.62kB (-0.03%) ⬇️

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3579      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         806      806              
  Lines       14478    14472       -6     
  Branches     4105     4103       -2     
==========================================
- Hits        14321    14315       -6     
  Misses        150      150              
  Partials        7        7              
Files with missing lines Coverage Δ
...ervices/selfHosted/SelfHostedHasAdminsQueryOpts.ts 100.00% <100.00%> (ø)
...issingDesignatedAdmins/MissingDesignatedAdmins.jsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <100.00%> (-0.01%) ⬇️
Shared 99.32% <100.00%> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05416a...6667d57. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (c05416a) to head (6667d57).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3579      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         806      806              
  Lines       14478    14472       -6     
  Branches     4112     4110       -2     
==========================================
- Hits        14321    14315       -6     
  Misses        150      150              
  Partials        7        7              
Files with missing lines Coverage Δ
...ervices/selfHosted/SelfHostedHasAdminsQueryOpts.ts 100.00% <100.00%> (ø)
...issingDesignatedAdmins/MissingDesignatedAdmins.jsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <100.00%> (-0.01%) ⬇️
Shared 99.32% <100.00%> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05416a...6667d57. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (c05416a) to head (6667d57).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3579      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         806      806              
  Lines       14478    14472       -6     
  Branches     4105     4103       -2     
==========================================
- Hits        14321    14315       -6     
  Misses        150      150              
  Partials        7        7              
Files with missing lines Coverage Δ
...ervices/selfHosted/SelfHostedHasAdminsQueryOpts.ts 100.00% <100.00%> (ø)
...issingDesignatedAdmins/MissingDesignatedAdmins.jsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <100.00%> (-0.01%) ⬇️
Shared 99.32% <100.00%> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05416a...6667d57. Read the comment docs.

Copy link

codecov bot commented Dec 13, 2024

Bundle Report

Changes will decrease total bundle size by 3.08kB (-0.02%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.67MB 1.62kB (-0.03%) ⬇️
gazebo-production-system-esm 5.72MB 1.46kB (-0.03%) ⬇️

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (c05416a) to head (6667d57).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3579      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         806      806              
  Lines       14478    14472       -6     
  Branches     4105     4103       -2     
==========================================
- Hits        14321    14315       -6     
  Misses        150      150              
  Partials        7        7              
Files with missing lines Coverage Δ
...ervices/selfHosted/SelfHostedHasAdminsQueryOpts.ts 100.00% <100.00%> (ø)
...issingDesignatedAdmins/MissingDesignatedAdmins.jsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <100.00%> (-0.01%) ⬇️
Shared 99.32% <100.00%> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05416a...6667d57. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
6667d57 Fri, 13 Dec 2024 14:25:32 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants