Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate useSelfHostedSeatsAndLicense to TS Query V5 #3577

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: Migrate useSelfHostedSeatsAndLicense to TS Query V5 #3577

wants to merge 4 commits into from

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the useSelfHostedSeatsAndLicense to the TSQ V5 query options version SelfHostedSeatsAndLicenseQueryOpts, as well as a TS migration

Ticket: codecov/engineering-team#2961

Notable Changes

  • Migrate useSelfHostedSeatsAndLicense to SelfHostedSeatsAndLicenseQueryOpts
  • Update SelfHostedLicenseExpiration
    • Refactor to TS
    • Add in tiny wrapper component so that we can short circuit rendering the actual banner and triggering the data fetching, as suspense queries cannot be controlled via an enabled property

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 3.12kB (-0.02%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.67MB 1.65kB (-0.03%) ⬇️
gazebo-production-system-esm 5.72MB 1.48kB (-0.03%) ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Dec 12, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 3.12kB (-0.02%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.72MB 1.48kB (-0.03%) ⬇️
gazebo-staging-system 5.67MB 1.65kB (-0.03%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (617411d) to head (b5e0433).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3577      +/-   ##
==========================================
- Coverage   98.90%   98.90%   -0.01%     
==========================================
  Files         806      806              
  Lines       14485    14473      -12     
  Branches     4116     4105      -11     
==========================================
- Hits        14327    14315      -12     
  Misses        151      151              
  Partials        7        7
Files with missing lines Coverage Δ
...s/selfHosted/SelfHostedSeatsAndLicenseQueryOpts.ts 100.00% <100.00%> (ø)
...dLicenseExpiration/SelfHostedLicenseExpiration.tsx 97.05% <100.00%> (ø)

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (-0.01%) ⬇️
Services 99.36% <100.00%> (+0.03%) ⬆️
Shared 99.26% <100.00%> (-0.08%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617411d...b5e0433. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3577      +/-   ##
==========================================
- Coverage   98.90%   98.90%   -0.01%     
==========================================
  Files         806      806              
  Lines       14485    14473      -12     
  Branches     4116     4105      -11     
==========================================
- Hits        14327    14315      -12     
  Misses        151      151              
  Partials        7        7
Files with missing lines Coverage Δ
...s/selfHosted/SelfHostedSeatsAndLicenseQueryOpts.ts 100.00% <100.00%> (ø)
...dLicenseExpiration/SelfHostedLicenseExpiration.tsx 97.05% <100.00%> (ø)

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (-0.01%) ⬇️
Services 99.36% <100.00%> (+0.03%) ⬆️
Shared 99.26% <100.00%> (-0.08%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617411d...b5e0433. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (617411d) to head (b5e0433).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3577      +/-   ##
==========================================
- Coverage   98.90%   98.90%   -0.01%     
==========================================
  Files         806      806              
  Lines       14485    14473      -12     
  Branches     4116     4098      -18     
==========================================
- Hits        14327    14315      -12     
  Misses        151      151              
  Partials        7        7
Files with missing lines Coverage Δ
...s/selfHosted/SelfHostedSeatsAndLicenseQueryOpts.ts 100.00% <100.00%> (ø)
...dLicenseExpiration/SelfHostedLicenseExpiration.tsx 97.05% <100.00%> (ø)

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (-0.01%) ⬇️
Services 99.36% <100.00%> (+0.03%) ⬆️
Shared 99.26% <100.00%> (-0.08%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617411d...b5e0433. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (617411d) to head (b5e0433).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3577      +/-   ##
==========================================
- Coverage   98.90%   98.90%   -0.01%     
==========================================
  Files         806      806              
  Lines       14485    14473      -12     
  Branches     4109     4098      -11     
==========================================
- Hits        14327    14315      -12     
  Misses        151      151              
  Partials        7        7
Files with missing lines Coverage Δ
...s/selfHosted/SelfHostedSeatsAndLicenseQueryOpts.ts 100.00% <100.00%> (ø)
...dLicenseExpiration/SelfHostedLicenseExpiration.tsx 97.05% <100.00%> (ø)

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (-0.01%) ⬇️
Services 99.36% <100.00%> (+0.03%) ⬆️
Shared 99.26% <100.00%> (-0.08%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617411d...b5e0433. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Dec 12, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
b5e0433 Thu, 12 Dec 2024 19:16:37 GMT Expired Expired
b5e0433 Thu, 12 Dec 2024 19:20:34 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholas-codecov @codecov-releaser