chore: Migrate useSelfHostedUserList to TS Query V5 #3575
Conversation
Bundle ReportChanges will increase total bundle size by 233 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 233 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3575 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14485 14488 +3
Branches 4116 4108 -8
=======================================
+ Hits 14327 14330 +3
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3575 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14485 14488 +3
Branches 4116 4115 -1
=======================================
+ Hits 14327 14330 +3
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3575 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14485 14488 +3
Branches 4109 4108 -1
=======================================
+ Hits 14327 14330 +3
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3575 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14485 14488 +3
Branches 4116 4108 -8
=======================================
+ Hits 14327 14330 +3
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
| ) | ||
|
|
||
| return { | ||
| ...rest, |
There was a problem hiding this comment.
any chance we can avoid using ...rest here? Do we really need everything coming back from this query call?
| }) | ||
|
|
||
| describe('hook can fetch the next dataset', () => { | ||
| describe('not other options set', () => { |
There was a problem hiding this comment.
nit: no instead of not
| isAdmin?: boolean | ||
| } | ||
|
|
||
| const useQueryMembersList = (params: Params) => { |
There was a problem hiding this comment.
Im also kinda curious why we pulled the memo out of the query and into this new query in the component itself
Description
This PR migrates the
useSelfHostedUserListto the infiniteQueryOptions setup from TS Query V5 toSelfHostedUserListQueryOptsTicket: codecov/engineering-team#2961
Notable Changes
useSelfHostedUserListtoSelfHostedUserListQueryOptsMemberTable