Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content layout shift fix, form label common component, and other changes #2899

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sashaboi
Copy link

@sashaboi sashaboi commented May 24, 2024

Changes

I have added a few things :

  1. Form Label component : more uniform label for dropdowns
  2. Fix top margin at /account/github/<username> which gave a bit of a content shift for the first tab
  3. Clear filters label horizontal align
  4. Gap between label and dropdown for src/pages/AnalyticsPage/ChartSelectors/ChartSelectors.jsx made uniform
  5. Bundle summary content shift made uniform
  6. Bundles asset table drop down arrow alignment

Description

Video explanation : https://github.com/codecov/gazebo/assets/75421090/3abefbd7-3cd1-4d5f-9452-7c08519f909d

Notable Changes

Addition of FormLabel component & tests

Disclaimer

Most of these are nitpicks but as a frontend person these keep me up at night 💀
Finally found time now to pick these after going through Codecov during my interview at Sentry last month.
This is my fun account , I have earlier contributed through @onkardeshpande93

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@nicholas-codecov nicholas-codecov self-requested a review May 28, 2024 14:37
@sashaboi
Copy link
Author

sashaboi commented Jun 5, 2024

@nicholas-codecov how could i make your job easy as a reviewer? should I break down each change into separate prs and videos, so it would be easier to review and merge?

@nicholas-codecov
Copy link
Contributor

Sorry @sashaboi, I've been a bit busy getting caught back up with things after a couple days PTO, I'm taking a peak now.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
c3067d6 Wed, 05 Jun 2024 10:27:55 GMT Cloud Enterprise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering @sashaboi if you're alright refactoring this component to a new composable style that we've introduced here at Codecov. Here's an example, if you have any questions let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants