Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent - Token required because branch is protected #1580

Open
AndreKurait opened this issue Sep 26, 2024 · 15 comments
Open

Inconsistent - Token required because branch is protected #1580

AndreKurait opened this issue Sep 26, 2024 · 15 comments
Assignees
Labels
Area: Report Upload Issues with pre-ingest report uploading bug Something isn't working high High Priority Issues (to be fixed within 2 sprints)

Comments

@AndreKurait
Copy link

AndreKurait commented Sep 26, 2024

On a public repo, i'm getting inconsistent results with codecov-v4

e.g. opensearch-project/opensearch-migrations#1016

First Run - Successful

Run codecov/codecov-action@v4
evenName: pull_request
baseRef: opensearch-project:main | headRef: AndreKurait:FixSetHeaderExtraArgs
==> Fork detected, tokenless uploading used
evenName: pull_request
baseRef: opensearch-project:main | headRef: AndreKurait:FixSetHeaderExtraArgs
==> Fork detected, tokenless uploading used
evenName: pull_request
baseRef: opensearch-project:main | headRef: AndreKurait:FixSetHeaderExtraArgs
==> Fork detected, tokenless uploading used
==> linux OS detected
https://cli.codecov.io/latest/linux/codecov.SHA256SUM
gpg: directory '/home/runner/.gnupg' created
gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
gpg: /home/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <[email protected]>" imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg: Signature made Fri Aug [16](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:17) 23:23:14 2024 UTC
gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869
==> Uploader SHASUM verified (eb90[20](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:21)09cb800fdefbce291c1357953f80e29382f43c7a98cce3b57d2b4d8cec  codecov)
==> Running version latest
==> Running version v0.7.4
==> Running git config --global --add safe.directory /home/runner/work/opensearch-migrations/opensearch-migrations
/usr/bin/git config --global --add safe.directory /home/runner/work/opensearch-migrations/opensearch-migrations
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit --git-service github -C cea160a44ad1038bdd62054da250f1655206d1b8 -Z
info - 2024-09-25 [21](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:22):23:42,715 -- ci service found: github-actions
info - 2024-09-25 21:[23](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:24):42,723 -- The PR is happening in a forked repo. Using tokenless upload.
info - 20[24](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:25)-09-25 21:23:43,132 -- Process Commit creating complete
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report --git-service github -C cea160a44ad1038bdd62054da[25](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:26)0f1655206d1b8 -Z
info - 2024-09-25 21:23:43,847 -- ci service found: github-actions
info - 2024-09-25 21:23:44,[28](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:29)6 -- Process Report creating complete
info - 2024-09-25 21:23:44,286 -- Finished creating report successfully --- {"response": "{\"status\":\"queued\"}\n"}
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov do-upload'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov do-upload -Z -f ./coverage.xml --git-service github -C cea160a44ad1038bdd62054da250f1655206d1b8
info - 2024-09-25 21:23:45,002 -- ci service found: github-actions
warning - 2024-09-25 21:23:45,010 -- xcrun is not installed or can't be found.
warning - 2024-09-25 21:23:45,0[32](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:33) -- No gcov data found.
warning - 2024-09-25 21:23:45,032 -- coverage.py is not installed or can't be found.
warning - 2024-09-25 21:23:45,059 -- Some files were not found --- {"not_found_files": ["coverage.xml"]}
info - 2024-09-25 21:23:45,092 -- Found 1 coverage files to report
info - 2024-09-25 21:23:45,092 -- > /home/runner/work/opensearch-migrations/opensearch-migrations/TrafficCapture/dockerSolution/src/main/docker/migrationConsole/console_api/coverage.xml
info - 2024-09-25 21:23:45,684 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/opensearch-project/opensearch-migrations/commit/cea160a44ad10[38](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:39)bdd62054da250f1655206d1b8
info - 2024-09-25 21:23:45,975 -- Process Upload complete

Subsequent Run - Failure

Run codecov/codecov-action@v4
evenName: pull_request
baseRef: opensearch-project:main | headRef: AndreKurait:FixSetHeaderExtraArgs
==> Fork detected, tokenless uploading used
evenName: pull_request
baseRef: opensearch-project:main | headRef: AndreKurait:FixSetHeaderExtraArgs
==> Fork detected, tokenless uploading used
evenName: pull_request
baseRef: opensearch-project:main | headRef: AndreKurait:FixSetHeaderExtraArgs
==> Fork detected, tokenless uploading used
==> linux OS detected
https://cli.codecov.io/latest/linux/codecov.SHA256SUM
gpg: directory '/home/runner/.gnupg' created
gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
gpg: /home/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <[email protected]>" imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg: Signature made Fri Aug [16](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:17) 23:23:14 2024 UTC
gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869
==> Uploader SHASUM verified (eb902009cb800fdefbce291c1357953f80e29382f43c7a98cce3b57d2b4d8cec  codecov)
==> Running version latest
==> Running version v0.7.4
==> Running git config --global --add safe.directory /home/runner/work/opensearch-migrations/opensearch-migrations
/usr/bin/git config --global --add safe.directory /home/runner/work/opensearch-migrations/opensearch-migrations
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit --git-service github -C cb162006e653a[17](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:18)23ec910d17de13b0ea8525550 -Z
info - 2024-09-26 18:44:15,790 -- ci service found: github-actions
info - 2024-09-26 [18](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:19):44:15,798 -- The PR is happening in a forked repo. Using tokenless upload.
info - [20](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:21)24-09-26 18:44:16,057 -- Process Commit creating complete
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report --git-service github -C cb162006e653a17[23](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:24)ec910d17de13b0ea8525550 -Z
info - 2024-09-26 18:44:16,771 -- ci service found: github-actions
info - 20[24](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:25)-09-26 18:44:17,038 -- Process Report creating complete
error - 2024-09-[26](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11058330515/job/30724095698?pr=1016#step:5:27) 18:44:17,039 -- Report creating failed: {"message":"Token required because branch is protected"}
Error: Codecov:
                        Failed to properly create report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
0s
@AndreKurait
Copy link
Author

Workaround is to close the PR and make a new one e.g. opensearch-project/opensearch-migrations#1019

@G-Rath
Copy link

G-Rath commented Oct 8, 2024

I'm getting this quite a lot suddenly on https://github.com/google/osv-scanner - this only started happening in the last couple of weeks and afaik there have not been any changes to the branch protection rules (@another-rex could you confirm this?)

Some action examples:

@greg0ire
Copy link

@thomasrockhu can you please look into this one? 🙏

@greg0ire
Copy link

@thomasrockhu-codecov seems to be a better handle to ping :)

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Oct 22, 2024
@thomasrockhu-codecov thomasrockhu-codecov added bug Something isn't working Area: Report Upload Issues with pre-ingest report uploading Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months high High Priority Issues (to be fixed within 2 sprints) and removed Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months labels Oct 22, 2024
@thomasrockhu-codecov
Copy link
Contributor

@greg0ire @AndreKurait noting that I see this. Am asking the team what the expected behavior is but from what I can tell, we have always had protected branches require a token.

@AndreKurait have you seen this come up again or was it that one time?

@thomasrockhu-codecov
Copy link
Contributor

@G-Rath please let me know if there was a change in branch protection rules

@G-Rath
Copy link

G-Rath commented Nov 4, 2024

@thomasrockhu-codecov I don't know as I'm not the owner of the repository, but I've not seen this failure for a few weeks so I assume it's just been fixed 🤷

@greg0ire
Copy link

greg0ire commented Nov 4, 2024

@thomasrockhu-codecov I no longer see the _error message on my repository, but I still have an issue: the upload is never processed. I will file a separate bug report.

@greg0ire
Copy link

greg0ire commented Nov 4, 2024

Here it is: #1633

@thomasrockhu-codecov
Copy link
Contributor

Going to close this one out for now, @greg0ire I'll take a look at that issue

@AndreKurait
Copy link
Author

@thomasrockhu-codecov I just hit this again, can we reopen this?

I only ever get it after pushing multiple commits after creating a PR.

It appears to be a bug in detecting the fork ==> Fork detected, tokenless uploading used, whereas the PR and action is on a public repo.

https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120

Run codecov/codecov-action@v4
  with:
    files: ./coverage.xml
    flags: python-test
    fail_ci_if_error: true
  env:
    python-version: 3.11
    java-version: 11
    gradle-version: 8.0.[2](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:2)
    node-version: 18.x
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:3).11.10/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.10/x6[4](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:4)/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.10/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.10/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.10/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.10/x64/lib
eventName: pull_request
baseRef: opensearch-project:main | headRef: AndreKurait:ClusterTools
==> Fork detected, tokenless uploading used
==> linux OS detected
https://cli.codecov.io/latest/linux/codecov.SHA2[5](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:5)6SUM
gpg: directory '/home/runner/.gnupg' created
gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
gpg: /home/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 80[6](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:6)BB28AED[7](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:7)79869: public key "Codecov Uploader (Codecov Uploader Verification Key) <[email protected]>" imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg: Signature made Fri Oct 1[8](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:8) 16:02:53 2024 UTC
gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED77[9](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:9)869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869
==> Uploader SHASUM verified (452ad3c57dc4ff698e9ca36786a2d09be5db254c32c4a4fb6d08c18146e4d8c1  codecov)
==> Running version latest
==> Running version v0.8.0
==> Running git config --global --add safe.directory /home/runner/work/opensearch-migrations/opensearch-migrations
/usr/bin/git config --global --add safe.directory /home/runner/work/opensearch-migrations/opensearch-migrations
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit --git-service github -B AndreKurait:ClusterTools -C 0a777ce0e5265921a8b2a4f682300[10](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:10)5f085a2ad -Z
info - 2024-[11](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:11)-07 15:44:12,801 -- ci service found: github-actions
info - 2024-11-07 15:44:[12](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:12),811 -- The PR is happening in a forked repo. Using tokenless upload.
info - 2024-11-07 15:44:[13](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:13),304 -- Process Commit creating complete
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report --git-service github -C 0a777ce0e5265921a8b2a4f682300105f085a2ad -Z
info - 2024-11-07 15:44:[14](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:14),021 -- ci service found: github-actions
info - 2024-11-07 [15](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664937244?pr=1120#step:5:15):44:14,451 -- Process Report creating complete
error - 2024-11-07 15:44:14,451 -- Report creating failed: {"message":"Token required because branch is protected"}
Error: Codecov:
                        Failed to properly create report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

@AndreKurait
Copy link
Author

It's inconsistent because another action on the same commit passed

0s
1m 18s
5s
Run codecov/codecov-action@v4
eventName: pull_request
baseRef: opensearch-project:main | headRef: AndreKurait:ClusterTools
==> Fork detected, tokenless uploading used
==> linux OS detected
https://cli.codecov.io/latest/linux/codecov.SHA256SUM
gpg: directory '/home/runner/.gnupg' created
gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
gpg: /home/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <[email protected]>" imported
gpg: Total number processed: [1](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664938292?pr=1120#step:5:1)
gpg:               imported: 1
gpg: Signature made Fri Oct [18](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664938292?pr=1120#step:5:19) 16:02:53 2024 UTC
gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869
==> Uploader SHASUM verified (452ad3c57dc4ff698e9ca36786a2d09be5db254c32c4a4fb6d08c18146e4d8c1  codecov)
==> Running version latest
==> Running version v0.8.0
==> Running git config --global --add safe.directory /home/runner/work/opensearch-migrations/opensearch-migrations
/usr/bin/git config --global --add safe.directory /home/runner/work/opensearch-migrations/opensearch-migrations
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit --git-service github -B AndreKurait:ClusterTools -C 0a777ce0e5265921a8b2a4f682300105f085a2ad -Z
info - 2024-11-07 15:45:03,116 -- ci service found: github-actions
info - 2024-11-07 15:45:03,126 -- The PR is happening in a forked repo. Using tokenless upload.
info - 2024-11-07 15:45:03,626 -- Process Commit creating complete
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report --git-service github -C 0a777ce0e5265921a8b2a4f682300105f085a2ad -Z
info - 2024-11-07 15:45:04,340 -- ci service found: github-actions
info - 2024-11-07 15:45:05,[19](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664938292?pr=1120#step:5:20)3 -- Process Report creating complete
info - [20](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664938292?pr=1120#step:5:21)24-11-07 15:45:05,194 -- Finished creating report successfully --- {"response": "{\"status\":\"queued\"}\n"}
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov do-upload'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov do-upload -Z -f ./coverage.xml -F python-test --git-service github -C 0a777ce0e52659[21](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664938292?pr=1120#step:5:22)a8b2a4f682300105f085a2ad
info - 2024-11-07 15:45:05,908 -- ci service found: github-actions
warning - 2024-11-07 15:45:05,919 -- xcrun is not installed or can't be found.
warning - 2024-11-07 15:45:05,944 -- No gcov data found.
warning - 2024-11-07 15:45:05,944 -- coverage.py is not installed or can't be found.
warning - 2024-11-07 15:45:05,976 -- Some files were not found --- {"not_found_files": ["coverage.xml"]}
info - 2024-11-07 15:45:06,016 -- Found 1 coverage files to report
info - 2024-11-07 15:45:06,016 -- > /home/runner/work/opensearch-migrations/opensearch-migrations/TrafficCapture/dockerSolution/src/main/docker/migrationConsole/cluster_tools/coverage.xml
info - 2024-11-07 15:45:06,568 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/opensearch-project/opensearch-migrations/commit/0a777ce0e5265921a8b2a4f68[23](https://github.com/opensearch-project/opensearch-migrations/actions/runs/11726398842/job/32664938292?pr=1120#step:5:24)00105f085a2ad
info - 2024-11-07 15:45:06,750 -- Process Upload complete

@thomasrockhu-codecov
Copy link
Contributor

@AndreKurait got it, taking a look

@bobleesj
Copy link

bobleesj commented Nov 7, 2024

@thomasrockhu-codecov Not sure if would help but wanted to share that we are seeing this issue too. No branch projection has been added.

The first commit passes diffpy/diffpy.utils@87a5b6d, but when a new commit (diffpy/diffpy.utils@f45ba82) is added, it starts to fail with the message.

@thomasrockhu-codecov
Copy link
Contributor

This one is really strange, I'm syncing with the product team to try to understand why this is happening.

That said, we are planning to release action@v5 in the next 2 weeks (likely next week) which SHOULD fix this issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Report Upload Issues with pre-ingest report uploading bug Something isn't working high High Priority Issues (to be fixed within 2 sprints)
Projects
None yet
Development

No branches or pull requests

5 participants