Code

Code smells#1007

Code

Open

BouaoudMalik wants to merge 8 commits intocode4craft:developcode4craft/webmagic:developfrom BouaoudMalik:code_smellsBouaoudMalik/webmagic:code_smellsCopy head branch name to clipboard

+48-34

Commits

Commits on Mar 18, 2021

• re interrupting reinterrupting waitNewUrl and sleep after the interruptException is catched

  

  Malik Bouaoud

  authored and

  Malik Bouaoud

  committed
  7d753cc

  Copy full SHA for 7d753cc

• adding a nullPointerException that could be thrown by the IPUtils method

  

  Malik Bouaoud

  authored and

  Malik Bouaoud

  committed
  8d3c73a

  Copy full SHA for 8d3c73a

Commits on Mar 23, 2021

• refactoring on constructors and setters

  

  Malik Bouaoud

  authored and

  Malik Bouaoud

  committed
  13f9840

  Copy full SHA for 13f9840

• removing some code smells in Page from webmagic core

  

  Malik Bouaoud

  authored and

  Malik Bouaoud

  committed
  246526b

  Copy full SHA for 246526b

Commits on Mar 30, 2021

• correcting and removing some code smell in spider from webmagic core

  

  Malik Bouaoud

  authored and

  Malik Bouaoud

  committed
  de34155

  Copy full SHA for de34155

• deleting deprecated method created 8 years ago

  

  Malik Bouaoud

  authored and

  Malik Bouaoud

  committed
  1946b3f

  Copy full SHA for 1946b3f

• adding the deprecated methods to validate the pull request

  

  Malik Bouaoud

  authored and

  Malik Bouaoud

  committed
  42c326b

  Copy full SHA for 42c326b

• refactoring on the select method with remooving continue statement and merging some condition

  

  Malik Bouaoud

  authored and

  Malik Bouaoud

  committed
  5ae7079

  Copy full SHA for 5ae7079