-
Notifications
You must be signed in to change notification settings - Fork 16
feat(nx-plugin): adjust bin path handling #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit 24b5d03
☁️ Nx Cloud last updated this comment at |
View your CI Pipeline Execution ↗ for commit 695acbc ☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/core
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 5e7bc63 with previous commit 3b5db5b. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👍 2 audits improved, 👎 2 audits regressed, 16 audits changed without impacting score🗃️ Groups
20 other groups are unchanged. 🛡️ Audits
590 other audits are unchanged. |
packages/nx-plugin/package.json
Outdated
"zod": "^4.0.5", | ||
"chalk": "5.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have ansis
for terminal colors, please use it instead of introudcing a new dependency.
"zod": "^4.0.5", | |
"chalk": "5.3.0" | |
"zod": "^4.0.5" |
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Precondition:
This PR includes:
cli
project'nx-plugin
projects executors (not the target inference)Note
After this is merged is should be possible to use it locally like this:
_nx.json.defaultTargets
or
nx.json.plugins
Then run:
nx code-pushup
You will see a log that prints the executed command as copy past version for you to re-ensure the setup.
NODE_OPTIONS="--import tsx" TSX_TSCONFIG_PATH="tsconfig.base.json" npx @code-pushup/cli --verbose --no-progress --config="code-pushup.config.ts" --upload.project="cli-workspace"
The only thing that is left but blocked by Nx, is using the local target inference code with external dependencies.
Another precondition of: