Revert "fix: updates build config and adjust tests (#458)"

This reverts commit d3fa849.
code-differently · Oct 27, 2024 · 7fa8ece · 7fa8ece
1 parent d3fa849
commit 7fa8ece
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 31 deletions.
diff --git a/lesson_13/maps_java/maps_app/build.gradle.kts b/lesson_13/maps_java/maps_app/build.gradle.kts
@@ -32,7 +32,7 @@ dependencies {
 
 application {
     // Define the main class for the application.
-    mainClass.set("com.codedifferently.lesson13.Lesson13")
+    mainClass.set("com.codedifferently.lesson12.Lesson12")
 }
 
 tasks.named<Test>("test") {

diff --git a/lesson_14/exceptions/exceptions_app/build.gradle.kts b/lesson_14/exceptions/exceptions_app/build.gradle.kts
@@ -32,7 +32,7 @@ dependencies {
 
 application {
     // Define the main class for the application.
-    mainClass.set("com.codedifferently.lesson14.Lesson14")
+    mainClass.set("com.codedifferently.lesson12.Lesson12")
 }
 
 tasks.named<Test>("test") {

diff --git a/.../exceptions_app/src/main/java/com/codedifferently/lesson14/ecommerce/EcommerceSystem.java b/.../exceptions_app/src/main/java/com/codedifferently/lesson14/ecommerce/EcommerceSystem.java
@@ -5,7 +5,6 @@
 import java.util.UUID;
 
 public class EcommerceSystem {
-
   private Map<String, Product> products;
   private Map<String, Order> orders;
 
@@ -18,11 +17,8 @@ public void addProduct(String productId, String name) {
     products.put(productId, new Product(productId, name));
   }
 
-  public String placeOrder(String productId, int quantity) throws ProductNotFoundException {
+  public String placeOrder(String productId, int quantity) {
     Product product = products.get(productId);
-    if (product == null) {
-      throw new ProductNotFoundException("Product with ID " + productId + " not found");
-    }
     String orderId = UUID.randomUUID().toString();
     orders.put(orderId, new Order(orderId, product, quantity));
     return orderId;
@@ -32,11 +28,8 @@ public void cancelOrder(String orderId) {
     orders.remove(orderId);
   }
 
-  public String checkOrderStatus(String orderId) throws OrderNotFoundException {
+  public String checkOrderStatus(String orderId) {
     Order order = orders.get(orderId);
-    if (order == null) {
-      throw new OrderNotFoundException("Order with ID " + orderId + " not found");
-    }
     return "Order ID: "
         + orderId
         + ", Product: "

diff --git a/...ns_app/src/main/java/com/codedifferently/lesson14/ecommerce/ProductNotFoundException.java b/...ns_app/src/main/java/com/codedifferently/lesson14/ecommerce/ProductNotFoundException.java
@@ -2,11 +2,7 @@
  * Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
  * Click nbfs://nbhost/SystemFileSystem/Templates/Classes/Class.java to edit this template
  */
-package com.codedifferently.lesson14.ecommerce;
 
-class ProductNotFoundException extends RuntimeException {
+package com.codedifferently.lesson14.ecommerce;
 
-  ProductNotFoundException(String message) {
-    super(message);
-  }
-}
+class ProductNotFoundException {}
diff --git a/...eptions_app/src/test/java/com/codedifferently/lesson14/ecommerce/EcommerceSystemTest.java b/...eptions_app/src/test/java/com/codedifferently/lesson14/ecommerce/EcommerceSystemTest.java
@@ -40,11 +40,6 @@ void testPlaceOrder_productDoesNotExist() throws Exception {
     assertThatThrownBy(() -> ecommerceSystem.placeOrder("1", 1))
         .isInstanceOf(ProductNotFoundException.class)
         .hasMessage("Product with ID 1 not found");
-
-    // Act
-    assertThatThrownBy(() -> ecommerceSystem.placeOrder("34", 1))
-        .isInstanceOf(ProductNotFoundException.class)
-        .hasMessage("Product with ID 34 not found");
   }
 
   @Test
@@ -63,23 +58,18 @@ void testCheckOrderStatus_orderDoesNotExist() {
     assertThatThrownBy(() -> ecommerceSystem.checkOrderStatus("1"))
         .isInstanceOf(OrderNotFoundException.class)
         .hasMessage("Order with ID 1 not found");
-
-    // Act
-    assertThatThrownBy(() -> ecommerceSystem.checkOrderStatus("33"))
-        .isInstanceOf(OrderNotFoundException.class)
-        .hasMessage("Order with ID 33 not found");
   }
 
   @Test
   void testCheckOrderStatus_orderCancelled() throws Exception {
     // Arrange
-    ecommerceSystem.addProduct("58", "Laptop");
-    String orderId = ecommerceSystem.placeOrder("58", 1);
+    ecommerceSystem.addProduct("1", "Laptop");
+    String orderId = ecommerceSystem.placeOrder("1", 1);
     ecommerceSystem.cancelOrder(orderId);
 
     // Act
-    assertThatThrownBy(() -> ecommerceSystem.checkOrderStatus("58"))
+    assertThatThrownBy(() -> ecommerceSystem.checkOrderStatus("1"))
         .isInstanceOf(OrderNotFoundException.class)
-        .hasMessage("Order with ID 58 not found");
+        .hasMessage("Order with ID 1 not found");
   }
 }