Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #1594 #1599

Open
wants to merge 1,029 commits into
base: master
Choose a base branch
from
Open

issue #1594 #1599

wants to merge 1,029 commits into from

Conversation

MohamedLebda
Copy link
Contributor

the browser's Same Origin Policy is blocking a cross-origin request to https://googleads.g.doubleclick.net/. This means that the browser is preventing the web page from accessing resources on a different domain than the one that served the web page.

The missing 'Access-Control-Allow-Origin' header is a CORS (Cross-Origin Resource Sharing) related issue. When a website makes a cross-origin request, the server needs to send this header along with the response to indicate which origins are allowed to access the resource. If this header is missing, the browser will block the request.

This issue could be causing problems with the functionality of the web page, depending on what resources are being requested from the remote domain.
issue1594

dodieboy and others added 30 commits September 23, 2022 21:40
Now hideDetailButton() use the svg path to read the button. This is to support all language.
Rework playback speed to be more intuitive
…tton

Fixed hide detail button not working
@ImprovedTube
Copy link
Member

hi @MohamedLebda, assigned you to #1594 quickly (about 4.0.17 from january), even if it is just for you to close it, just in case it adds any detail, since you researched autoplay. in future we can keep store and repo versions more synced.

googleads .... CORS

interesting, seen this once, how'd youtube's code relate to us there?


@raszpl
Copy link
Contributor

raszpl commented May 2, 2023

imo screwing with CORS is a big security nono, if google wants ads to work on YT they can fix this themselves, not to mention this might be viewed as malicious by the Extension store review process and result in removing from the store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.