Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

#22 - better serialisation for Tuples #62

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

josephw
Copy link

@josephw josephw commented Jun 14, 2012

Serialise tuples as:

[1, "two", 3.0]

rather than:

{ "_1": 1, "_2": "two", "_3": 3.0 }

@acruise
Copy link

acruise commented Jul 27, 2012

I haven't tested this yet, but it looks great to me. Could you do us a favour and write a test that proves that tuples serialized the old-fashioned way (e.g. { "_1": "foo", "_2": "bar" }) will still deserialize to tuples after your change?

@josephw
Copy link
Author

josephw commented Jul 29, 2012

Good catch. This version won't fall back to deserializing those tuples. I've made the change in josephw/jerkson@bc2b836, but I'm hitting an NPE constructing the fallback CaseClassDeserializer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants