fix safari can not resume the webaudio #17640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check ReportThis pull request does not change any public interfaces ! |
bofeng-song
reviewed
Sep 19, 2024
pal/audio/web/player-web.ts
Outdated
| // only state is suspended can involve resume function | ||
| if (context.state === 'suspended') { | ||
| context.resume().catch((e) => { debug.warn('runContext error', e); }); | ||
| } | ||
| if (context.state === 'running') { |
There was a problem hiding this comment.
The 'if' condition needs to be changed to 'else if'.
bofeng-song
reviewed
Sep 19, 2024
pal/audio/web/player-web.ts
Outdated
| // only state is suspended can involve resume function | ||
| if (context.state === 'suspended') { | ||
| context.resume().catch((e) => { debug.warn('runContext error', e); }); | ||
| } | ||
| if (context.state === 'running') { |
There was a problem hiding this comment.
The 'if' condition needs to be changed to 'else if'.
bofeng-song
reviewed
Sep 19, 2024
| context.resume().catch((e) => { debug.warn('runContext error', e); }); | ||
| // only state is suspended can involve resume function | ||
| if (context.state === 'suspended') { | ||
| context.resume().catch((e) => { debug.warn('runContext error', e); }); |
There was a problem hiding this comment.
After the logic change, will low-end devices be able to play normally?
There was a problem hiding this comment.
I have test ios 15.7 ios 14.8 and ios 17.5.1, three version of iphone.
bofeng-song
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #17637
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: