Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Target 390]Serialize BufferAsset as CCON #15513

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

shrinktofit
Copy link
Contributor

Re: #

Changelog

  • Adjust BufferAsset so that it can be serialized as CCON format.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

}

public validate () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the public API validate?

*/
@override
get _nativeAsset (): ArrayBuffer | ArrayBufferView {
return this._buffer as ArrayBuffer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overridden get/set _nativeAsset is removed. Will it break the compatibility?
The old get _nativeAsset return this._buffer, but now it returns this._file from its parent class Asset.

Copy link
Contributor Author

@shrinktofit shrinktofit Jul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the method documented, this is an engine private interface and has been deprecated since v3.5.0 and is explicitly starts with an underscore. We can directly removed it in v3.9.0.

@shrinktofit shrinktofit changed the base branch from develop to v3.8.1 August 3, 2023 02:19
@shrinktofit shrinktofit changed the title [Target 3.9.x] Serialize BufferAsset as CCON Serialize BufferAsset as CCON Aug 3, 2023
@shrinktofit shrinktofit changed the title Serialize BufferAsset as CCON [Target 390]Serialize BufferAsset as CCON Aug 9, 2023
@shrinktofit shrinktofit changed the base branch from v3.8.1 to develop August 16, 2023 07:58
@shrinktofit shrinktofit added this to the V3.9.0 milestone Sep 8, 2023
@shrinktofit shrinktofit marked this pull request as draft September 8, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants