Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rangeMin decorator from camera near #15129

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mvrlin
Copy link

@mvrlin mvrlin commented May 21, 2023

Re: When using Ortographic Projection it doesn't allow to set near less than zero and because of that, we can see through the mesh when it's close to the bottom of camera

As a temporary fix you can set _near property inside Camera component in scene
image

Changelog

  • remove rangeMin decorator from camera near

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@mvrlin
Copy link
Author

mvrlin commented May 24, 2023

Attaching a demo project
near-demo.zip

@mvrlin
Copy link
Author

mvrlin commented Jun 17, 2023

@pandamicro any update on this?

@minggo minggo requested review from GengineJS and removed request for jk20012001 December 19, 2023 07:55
@minggo
Copy link
Contributor

minggo commented Dec 19, 2023

It sounds reasonable.
@GengineJS please review it.

@GengineJS
Copy link
Contributor

In theory, setting the value of the near clipping plane to less than zero may lead to issues. This is because the near clipping plane is typically used to determine objects within the camera's field of view and is employed in depth testing. If the near clipping plane is set to a negative value, it may result in incorrect depth testing, potentially causing rendering anomalies or unpredictable outcomes.

@star-e
Copy link
Contributor

star-e commented Dec 20, 2023

We are fixing this in cocos creator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants