[Draft] Open Core #1059
Draft
[Draft] Open Core #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces the Range callback functions with the new iterator type compatible with the range keyword in go 1.23. The various map-like types receive iterator methods All(), Keys(), and Values(). The names of these methods are in line with the new iterator methods in the stdlib maps package. The Entries() and Range() methods are removed. The apply templates were the only actual use of Entries(), which has been hoisted into a template helper function to support deadlined columns. The net effect is to make flow-control more idiomatic. There were some cases where one would write "return nil" within a Range() callback when "continue" would be more natural or the use of "return sentinelError" when "break" would be the obvious choice. Many cases of always-nil error handling have been removed as well. The compiler has improved generic type inference and some explicit type parameterizations have been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on https://github.com/cockroachdb/replicator/tree/bob_core_open
This change is