lib: Rewrite "credentials" as a TypeScript class #21461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can do "if (err instanceof cockpit.ProcessError)" in catch clauses.
mvollmer
force-pushed
the
lib-type-credentials
branch
from
2f73b05 to
b3af36e
Compare
This requires its users to treat it as a class and not pass around divorced methods.
mvollmer
force-pushed
the
lib-type-credentials
branch
from
b3af36e to
2025537
Compare
cockpituous
reviewed
Dec 20, 2024
| @@ -198,25 +229,29 @@ function Keys() { | |||
| try { | |||
| await proc; | |||
| } catch (ex) { | |||
| if (ex.exit_status) | |||
| if (ex instanceof cockpit.ProcessError && ex.exit_status) | |||
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+299
to
+301
| ex = new KeyLoadError(sent_password, failure); | ||
| else if (error instanceof Error) | ||
| ex = new KeyLoadError(sent_password, error.message); |
There was a problem hiding this comment.
These 3 added lines are not executed by any test.
| else if (error instanceof Error) | ||
| ex = new KeyLoadError(sent_password, error.message); | ||
| else | ||
| ex = error; |
There was a problem hiding this comment.
This added line is not executed by any test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.