-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: Give secondary buttons more contrast in toolbars #21389
base: main
Are you sure you want to change the base?
lib: Give secondary buttons more contrast in toolbars #21389
Conversation
Technical review 👍 . Happy to give a formal ack if you already agreed on this with Garrett someplace else. Thanks! |
I agree with this sentiment and the CSS looks like what I'd suspect. I'd be able to approve it with a screenshot. 😉 |
Also: Note: This would affect all buttons, regardless of context (what other widgets they're in), so it might have some unknown effects in some places. It's probably correct, however. |
e2719dd
to
b6fd1f0
Compare
5a4731a
to
b268d77
Compare
Secondary buttons have a transparent background by default, which needs more contrast on grey backgrounds like in toolbars.
b268d77
to
169b0f2
Compare
Secondary buttons have a transparent background by default, which needs more contrast on grey backgrounds like in toolbars.