Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Give secondary buttons more contrast in toolbars #21389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented Dec 5, 2024

Secondary buttons have a transparent background by default, which needs more contrast on grey backgrounds like in toolbars.

@mvollmer mvollmer requested a review from garrett December 5, 2024 14:31
@martinpitt
Copy link
Member

Technical review 👍 . Happy to give a formal ack if you already agreed on this with Garrett someplace else. Thanks!

@martinpitt
Copy link
Member

@mvollmer would you mind putting a before/after screenshot? that may make it easier for @garrett to review.

@garrett
Copy link
Member

garrett commented Dec 12, 2024

I agree with this sentiment and the CSS looks like what I'd suspect. I'd be able to approve it with a screenshot. 😉

@garrett
Copy link
Member

garrett commented Dec 12, 2024

Also: Note: This would affect all buttons, regardless of context (what other widgets they're in), so it might have some unknown effects in some places.

It's probably correct, however.

@mvollmer mvollmer added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Dec 13, 2024
@mvollmer mvollmer force-pushed the pf-more-contrast-for-secondary-buttons branch from e2719dd to b6fd1f0 Compare December 13, 2024 08:20
@mvollmer mvollmer removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Dec 13, 2024
@mvollmer mvollmer force-pushed the pf-more-contrast-for-secondary-buttons branch 2 times, most recently from 5a4731a to b268d77 Compare December 13, 2024 10:19
@mvollmer mvollmer added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Dec 13, 2024
Secondary buttons have a transparent background by default, which
needs more contrast on grey backgrounds like in toolbars.
@mvollmer mvollmer force-pushed the pf-more-contrast-for-secondary-buttons branch from b268d77 to 169b0f2 Compare December 13, 2024 10:36
@mvollmer
Copy link
Member Author

mvollmer commented Dec 13, 2024

The hostswitcher has changed in light mode:

image

as opposed to earlier:

image

This does increase the contrast, and now the buttons have the same background color as the text input box. So I guess it's correct in that sense and looks as intended.

@mvollmer
Copy link
Member Author

The rest of the pixel changes are as expected. For example, the secondary buttons on the Networking page now look like this in dark mode:

image

as opposed to:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants