Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Haiku's wikidata url #143

Closed
wants to merge 1 commit into from
Closed

Changed Haiku's wikidata url #143

wants to merge 1 commit into from

Conversation

apoorvaagupta
Copy link
Member

Signed-off-by: Apoorvaa Gupta [email protected]

Fixes #123

Signed-off-by: Apoorvaa Gupta <[email protected]>
@apoorvaagupta
Copy link
Member Author

Hello @Makman2
I have just replaced the wrong wikidata url with the correct one in the data.min.json file on gh-pages branch. But this is showing some error in deploying thought I haven't changes any other file.
Please help!!

Copy link

@newbazz newbazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have not followed the commit guidelines.

@apoorvaagupta
Copy link
Member Author

Hello, @newbazz Can you please tell me my mistake?!
I am new to coala!

@ishanSrt
Copy link

ishanSrt commented Feb 3, 2018

@apoorvaagupta did you go through the newcomer's guide?
anyways here are the commit guidelines: https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

@ishanSrt
Copy link

ishanSrt commented Feb 3, 2018

Seriously what are the changes that you made?
screen shot 2018-02-04 at 2 30 35 am

@ishanSrt
Copy link

ishanSrt commented Feb 3, 2018

Does gitmate not check for the proper phrasing of commit messages? @newbazz what I mean is division of shortlog and/or body and last line

@jayvdb
Copy link
Member

jayvdb commented Apr 25, 2018

Changing the data file is not the correct solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants