Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync templates #616

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sync templates #616

wants to merge 1 commit into from

Conversation

Naveenaidu
Copy link
Member

@Naveenaidu Naveenaidu commented Aug 16, 2018

Reviewers Checklist

  • Appropriate logging is done.
  • Appropriate error responses.
  • Handle every possible exception.
  • Make sure there is a docstring in the command functions. Hint: Lookout for
    botcmd and re_botcmd decorators.
  • See that 100% coverage is there.
  • See to it that mocking is not done where it is not necessary.

@TravisBuddy
Copy link

Travis tests have failed

Hey @Naveenaidu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

python -m pytest
============================= test session starts ==============================
platform linux -- Python 3.6.3, pytest-3.6.4, py-1.5.2, pluggy-0.6.0
rootdir: /home/travis/build/coala/corobo, inifile: setup.cfg
plugins: requests-mock-1.5.2, xdist-1.22.5, travis-fold-1.3.0, timeout-1.3.1, reqs-0.1.0, reorder-0.1.1, profiling-1.3.0, mock-1.10.0, instafail-0.3.0, forked-0.2, error-for-skips-1.0.0, env-0.6.2, cov-2.5.1
_____________________ ERROR collecting plugins/coatils.py ______________________
/opt/python/3.6.3/lib/python3.6/doctest.py:933: in find
    self._find(tests, obj, name, module, source_lines, globs, {})
/opt/python/3.6.3/lib/python3.6/doctest.py:992: in _find
    if ((inspect.isroutine(inspect.unwrap(val))
/opt/python/3.6.3/lib/python3.6/inspect.py:509: in unwrap
    while _is_wrapper(func):
/opt/python/3.6.3/lib/python3.6/inspect.py:503: in _is_wrapper
    return hasattr(f, '__wrapped__')
../../../virtualenv/python3.6.3/lib/python3.6/site-packages/ramlient/core.py:132: in __getattr__
    raise ResourceNotFoundError(attr)
E   ramlient.errors.ResourceNotFoundError: No such Resource found: __wrapped__
collected 43 items / 1 errors / 3 skipped                                      


travis_fold:start:py-5737.cov.0
----------- coverage: platform linux, python 3.6.3-final-0 -----------
Name                                Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------
answers/__init__.py                     0      0      0      0   100%
plugins/__init__.py                     0      0      0      0   100%
plugins/constants.py                    5      0      0      0   100%
utils/__init__.py                       0      0      0      0   100%
utils/backends.py                       0      0      0      0   100%
plugins/lmgtfy.py                       4      1      0      0    75%   15
plugins/nevermind.py                    5      1      0      0    80%   14
plugins/ship_it.py                      7      1      0      0    86%   28
plugins/the_rules.py                    5      1      0      0    80%   19
plugins/deprecate_bot_prefixes.py       6      3      4      0    30%   15-17
plugins/ghetto.py                      10      5      2      0    42%   20-28
plugins/spam.py                        13      5      2      0    53%   19, 27-35
plugins/pitchfork.py                   12      6      2      0    43%   18-39
plugins/coala_lowercase_c.py           12      7      4      0    31%   11-26
plugins/searchdocs.py                  14      7      2      0    44%   23-30
plugins/explain.py                     20      9      6      0    50%   30-44
plugins/wolfram_alpha.py               19     12      6      0    28%   17-18, 25-34
utils/mixin.py                         20     14      6      0    23%   7-9, 12, 18-27, 30-38
plugins/answer.py                      31     20      8      0    28%   20-27, 31-61
plugins/git_stats.py                   51     43     19      0    11%   17-18, 25-77
plugins/coatils.py                    115    100     67      0     8%   20-21, 25-32, 46-97, 108-126, 130-140, 144-159, 172-241
-------------------------------------------------------------------------------
TOTAL                                 349    235    128      0    24%
travis_fold:end:py-5737.cov.0

FAIL Required test coverage of 100% not reached. Total coverage: 24.32%
=========================== short test summary info ============================
ERROR plugins/coatils.py
SKIP [1] /home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/_pytest/doctest.py:356: unable to import module local('/home/travis/build/coala/corobo/answers/extraction.py')
SKIP [1] /home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/_pytest/doctest.py:356: unable to import module local('/home/travis/build/coala/corobo/answers/final.py')
SKIP [1] /home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/_pytest/doctest.py:356: unable to import module local('/home/travis/build/coala/corobo/answers/service.py')
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
====================== 3 skipped, 1 error in 1.95 seconds ======================

@@ -18,6 +18,7 @@ addopts =
-p no:logging
--color=yes
--doctest-glob=*.rst
--doctest-modules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, this needs to be removed, or we need to fix a bug in an upstream library.
I'll look into that tomorrow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvzard
Copy link
Member

nvzard commented Jan 18, 2019

@Naveenaidu can you please try to sync again? That doctest-modules bug has been resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants