Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kotlin language #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Kotlin language #59

wants to merge 1 commit into from

Conversation

kiy4h
Copy link
Contributor

@kiy4h kiy4h commented Nov 23, 2018

No description provided.

jayvdb
jayvdb reviewed Nov 23, 2018
View reviewed changes
data/Language/Kotlin.yaml Outdated Show resolved Hide resolved
jayvdb
jayvdb reviewed Nov 23, 2018
View reviewed changes
data/Language/Kotlin.yaml Outdated Show resolved Hide resolved
@kiy4h kiy4h force-pushed the add-kotlin branch 2 times, most recently from 53da83a to 541db7d Compare November 23, 2018 02:28
Man-Jain
Man-Jain suggested changes Nov 24, 2018
View reviewed changes
data/Language/Kotlin.yaml Show resolved Hide resolved
jayvdb
jayvdb requested changes Dec 5, 2018
View reviewed changes
Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many of these datatypes duplicate existing datatypes already defined.

@jayvdb jayvdb requested a review from siddhpant December 5, 2018 15:59
siddhpant
siddhpant suggested changes Dec 5, 2018
View reviewed changes
Copy link
Member

@siddhpant siddhpant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datatypes already exist. Please don't make duplicates.

Please rebase the branch to remove duplicates residing in your branch before your changes too. #84 has merged some datatypes (actually all you need) in their specific file.

siddhpant
siddhpant reviewed Dec 5, 2018
View reviewed changes
data/DataType/byte_kotlin.yaml
@@ -0,0 +1,4 @@
keyword: byte
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use byte.yaml

siddhpant
siddhpant reviewed Dec 5, 2018
View reviewed changes
data/DataType/int_kotlin.yaml
@@ -0,0 +1,4 @@
keyword: int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use int.yaml

siddhpant
siddhpant reviewed Dec 5, 2018
View reviewed changes
data/DataType/long_kotlin.yaml
@@ -0,0 +1,4 @@
keyword: long
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use long2E63.yaml

siddhpant
siddhpant reviewed Dec 5, 2018
View reviewed changes
data/DataType/short_kotlin.yaml
@@ -0,0 +1,4 @@
keyword: short
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use short.yaml

siddhpant
siddhpant reviewed Dec 5, 2018
View reviewed changes
data/Delimiter/kotlin_char.yaml
@@ -0,0 +1,5 @@
type: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use c_char.yaml.

siddhpant
siddhpant reviewed Dec 5, 2018
View reviewed changes
data/DataType/double_kotlin.yaml
@@ -0,0 +1,4 @@
keyword: double
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use double_c.yaml

siddhpant
siddhpant reviewed Dec 5, 2018
View reviewed changes
data/DataType/float_kotlin.yaml
@@ -0,0 +1,4 @@
keyword: float
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use float_c.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddhpant siddhpant siddhpant requested changes

@Man-Jain Man-Jain Man-Jain requested changes

@jayvdb jayvdb jayvdb requested changes

Assignees
No one assigned
Labels
process/wip size/S
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiy4h @jayvdb @Man-Jain @siddhpant