-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
antlr4.yaml: Add g4 language #55
base: master
Are you sure you want to change the base?
Conversation
data/Language/antlr4.yaml
Outdated
- catch | ||
- finally | ||
- mode | ||
- options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing spaces (trailing-spaces)
Origin: YAMLLintBear, Section: yaml
.
@gitmate-bot rebase |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Automated rebase with GitMate.io was successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many more keywords , especially the very important 'skip' mentioned in https://github.com/antlr/antlr4/blob/master/doc/lexer-rules.md#lexer-commands
@jayvdb |
@jayvdb Alright, i will push changes once i get a break in between my exams. |
- g4 | ||
line_continuation: | ||
- backslash | ||
delimiters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we have a rule delimiter ;
as well. And lines are assumed to continue over any whitespace unless a rule delimiter is encountered.
example rule:
genericAssocList
: genericAssociation
| genericAssocList ',' genericAssociation
;
Although I haven't seen the statement delimiter mentioned in most of the languages, probably a useful thing to include ? (most new languages use a semicolon, but some older ones use newlines / full stops as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems practical, will add this too.
Comment on 44ebd02, file data/Language/Pascal.yaml, line 53. truthy value is not quoted (truthy) Origin: YAMLLintBear, Section: |
Comment on 44ebd02, file data/Language/VisualBasic.yaml, line 5. line too long (82 > 80 characters) (line-length) Origin: YAMLLintBear, Section: |
Comment on 44ebd02, file data/Language/VisualBasic.yaml, line 98. truthy value is not quoted (truthy) Origin: YAMLLintBear, Section: |
@jayvdb Now its good to go.Also, sorry for being late my exams are over now and i am free from everything.Now the "code like crazy" mode will begin. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments inline.
Closes #27