Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes for dedicated documentation website #94

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

guidemetothemoon
Copy link
Contributor

What type of PR is this?

kind/documentation

What this PR does / why we need it:

Reverting changes for having a dedicated documentation website. All documentation is located in the docs folder at the root of the repo. Markdown linter fixes and metadata for Hugo pages is preserved for the future place where this content will be available as part of the website.

Which issue(s) this PR fixes:

Related to #89

Special notes for your reviewer (optional):

Signed-off-by: Kristina Devochko <[email protected]>
@guidemetothemoon guidemetothemoon requested review from a team as code owners May 18, 2024 14:57
@guidemetothemoon guidemetothemoon added kind/documentation Improvements or additions to documentation board/wg-green-reviews labels May 18, 2024
Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We'll find a good home for these docs, eventually... 😅

Also thank you for preserving git history with git mv ! 🚀

@nikimanoledaki
Copy link
Contributor

nikimanoledaki commented May 18, 2024

Huh, I should be able to merge this PR (and was able to do so previously) but that's no longer possible. It requires a second approving review from @cncf-tags/tag-env-leads 🤔

Requiring 2 PR reviews would slow down the (already slow) pace of the project 🙈

@guidemetothemoon
Copy link
Contributor Author

I'm not sure who added the TAG ENV leads as reviewers - it wasn't me at least and I'm not sure if it's really needed for every PR? Maybe this is a consequence of some new governance rule that I'm not aware of...

@leonardpahlke @mkorbi please comment if you know anything about this change. I can't approve my own PR so one of you needs to review it as well.

@rossf7
Copy link
Contributor

rossf7 commented May 20, 2024

I'm not sure who added the TAG ENV leads as reviewers - it wasn't me at least and I'm not sure if it's really needed for every PR? Maybe this is a consequence of some new governance rule that I'm not aware of...

@guidemetothemoon this is due to the CODEOWNERS rules added in #82 There are a list of known file extensions that Green Reviews leads can approve and * that needs approval from TAG ENV leads.

The problem is reverting includes changes such as .toml that are not in the list. Once this is merged the rules will be correct again.

@leonardpahlke @mkorbi Can one of you review?

If this happens often we might need to look at the CODEOWNERS rules again.

@nikimanoledaki
Copy link
Contributor

nikimanoledaki commented May 21, 2024

Hey @rossf7, thank you for clarifying this! ☺️ What is the benefit of having this distinction? Could we move everything under @cncf-tags/tag-env-wg-green-reviews-leads? 🤔 The more people we can pool reviews+merging from, the faster the pace of the project. :)

Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#65 -- is still under discussion, and therefore it's not clear how many changes the PR would revert. Let's wait until the discussion is finalized.

auto-merge was automatically disabled June 10, 2024 11:52

Pull request was closed

@AntonioDiTuri AntonioDiTuri reopened this Jun 10, 2024
@AntonioDiTuri
Copy link
Contributor

Merging as discussed in #65 (comment)

@AntonioDiTuri AntonioDiTuri merged commit eb0b41d into main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board/wg-green-reviews kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants