Add draft of proposal 3 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisChinchilla
commented
Aug 21, 2024
Signed-off-by: Chris Chinchilla <[email protected]>
ChrisChinchilla
force-pushed
the
chrischinch/prop-3
branch
from
f9c97e4
to
9dd9ce0
Compare
rossf7
reviewed
Aug 30, 2024
Signed-off-by: Antonio Di Turi <[email protected]>
AntonioDiTuri
force-pushed
the
chrischinch/prop-3
branch
from
016a1b8
to
7f69670
Compare
Signed-off-by: Antonio Di Turi <[email protected]>
rossf7
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind/enhancement
What this PR does / why we need it:
Adds draft of proposal 3 to detail how and what metrics to record from the carbon emissions benchmark pipelines.
Which issue(s) this PR fixes:
Fixes #95
Special notes for your reviewer (optional):
I am not so good at this style of writing as I’m generally a more direct writer. I am also not sure what level of detail to add as a lot of what I have in the design details reproduces other proposals, but I needed somewhere to record the steps I have to follow. It could be all that’s needed are the steps for deciding the metrics and exporting them, which makes everything fairly simple. But I’m not sure, and then the document really doesn’t need much detail, and possibly I can ignore a lot of the headings.