This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors setting stuff in order to enable checkpoint manager to recover setting values. In addition, added some convenient functions.
- Fix Points of SettingsManager
txn
argument into set functions in order that a caller of set functions can manage a necessary transaction by itself.set_default
argument into set functions. If this flag argument is true, then the default value is updated in addition to updating the setting value.Reset
public function to reset the setting value to default value.UpdateSettingListFromCatalog()
public function to update setting values in the manager from catalog for checkpoints.InsertCatalog()
,UpdateCatalog()
.- Fix Points of SettingsCatalog
SettingsCatalogEntry
class to acquire all setting information from catalogGetSettingsCatalogEntry()
andGetSettingsCatalogEntries()
functions.*These function names are temporary. The permanent names depend on discussion in PR Catalog code cleanup #1414.
UpdateSettingValue()
function to update a setting value and a default value.- Related Issues