Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] support left-outer and left-mark hash join impl rules #274

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

yliang412
Copy link
Member

@yliang412 yliang412 commented Dec 22, 2024

Problem

We should be able to convert left-outer join and left-mark logical equi join to hash join.

Summary of changes

  • Add implementation rules to handle these cases.

misc

  • refactor simplify_log_expr to stop using unreachable!

Not ideal, wants to unite inner, left-outer, and left-mark into one rule

Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
Copy link
Member Author

tpch Q13 needs a rule to push split a filter from the join node, and then the join could be turned into a left-outer hash join. Working on this now.

...
  ├── cond:And
  │   ├── Eq
  │   │   ├── #0
  │   │   └── #9
  │   └── Like { expr: #16, pattern: "%special%requests%", negated: true, case_insensitive: false }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant