Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove latest epoch id and add some todo documentation comments #26

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

lanlou1554
Copy link
Contributor

  1. Remove latest_epoch_id in backend_manager since it is useless.
  2. Add some todo documentation comments for cost model piece

Copy link
Member

@connortsui20 connortsui20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just add the lazy cell from the other PR to fix the conflict)

@lanlou1554 lanlou1554 force-pushed the remove-latest-epoch-id branch from ef1d482 to beb6e60 Compare November 9, 2024 20:23
@lanlou1554 lanlou1554 changed the title Remove latest epoch id and add some todo documentation comments chore: remove latest epoch id and add some todo documentation comments Nov 9, 2024
@lanlou1554 lanlou1554 merged commit 9c98703 into main Nov 9, 2024
12 checks passed
@lanlou1554 lanlou1554 deleted the remove-latest-epoch-id branch November 9, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants