Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: stubbing out MySQL advanced monitoring support #550

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker/build-run-benchmark-with-docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ BUILD_IMAGE=false EXTRA_DOCKER_ARGS="--network=host $EXTRA_DOCKER_ARGS" \
--config "config/sample_${benchmark}_config.xml" --bench "$benchmark" \
--create=false --load=false --execute=true \
--sample 1 --interval-monitor 1000 \
--monitor-type advanced \
--json-histograms results/histograms.json
rc=$?
wait # for the interrupt script, if any
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ public static Monitor getMonitor(
case ADVANCED:
{
switch (conf.getDatabaseType()) {
case MARIADB:
case MYSQL:
return new MySQLMonitor(monitorInfo, testState, workers, conf);
case SQLSERVER:
return new SQLServerMonitor(monitorInfo, testState, workers, conf);
case POSTGRES:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
package com.oltpbenchmark.api.collectors.monitoring;

import com.oltpbenchmark.BenchmarkState;
import com.oltpbenchmark.WorkloadConfiguration;
import com.oltpbenchmark.api.BenchmarkModule;
import com.oltpbenchmark.api.Worker;
import com.oltpbenchmark.util.MonitorInfo;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.time.Instant;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

/**
* Implementation of a monitor specific to PostgreSQL. Uses the 'pg_stat_statements' add-on to
* extract relevant query and system information.
*/
public class MySQLMonitor extends DatabaseMonitor {

// TODO: add support for per-query metrics using performance_schema
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO


// TODO: Expand to SHOW ENGINE INNODB STATUS as well?
private final String MYSQL_SYSTEM_METRICS = "SHOW GLOBAL STATUS;";

private final List<String> repeatedSystemProperties;

public MySQLMonitor(
MonitorInfo monitorInfo,
BenchmarkState testState,
List<? extends Worker<? extends BenchmarkModule>> workers,
WorkloadConfiguration conf) {
super(monitorInfo, testState, workers, conf);

this.repeatedSystemProperties =
new ArrayList<String>() {
{
add("bytes_received");
add("bytes_sent");
add("com_select");
// ...
// TODO: Add more properties from SHOW STATUS here
}
};
}

@Override
protected String getCleanupStmt() {
// FIXME: Currently a no-op.
return "SELECT 1";
}

/**
* Extract system events using the extraction query and properties defined above, will fail
* gracefully to not interrupt benchmarking.
*/
private void extractPerformanceMetrics(Instant instant) {
ImmutableRepeatedSystemEvent.Builder repeatedSystemEventBuilder =
ImmutableRepeatedSystemEvent.builder();
repeatedSystemEventBuilder.instant(instant);

// Extract OS performance events.
Map<String, String> propertyValues = new HashMap<String, String>();
try (PreparedStatement stmt = conn.prepareStatement(MYSQL_SYSTEM_METRICS)) {
ResultSet rs = stmt.executeQuery();
while (rs.next()) {
// Add property values.
String metric_name = rs.getString(1).trim();
if (this.repeatedSystemProperties.contains(metric_name)) {
propertyValues.put(metric_name, rs.getString(2));
}
}
} catch (SQLException sqlError) {
LOG.error("Error when extracting system metrics from MySQL.");
LOG.error(sqlError.getMessage());
}
repeatedSystemEventBuilder.propertyValues(propertyValues);
this.repeatedSystemEvents.add(repeatedSystemEventBuilder.build());
}

@Override
protected void runExtraction() {
Instant time = Instant.now();

// TODO: extractQueryMetrics(time);
extractPerformanceMetrics(time);
}

@Override
protected void writeSystemMetrics() {
this.writeRepeatedSystemEventsToCSV();
}
}